Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A question about softcap. #1181

Closed
alex-ht opened this issue Aug 28, 2024 · 2 comments
Closed

A question about softcap. #1181

alex-ht opened this issue Aug 28, 2024 · 2 comments

Comments

@alex-ht
Copy link

alex-ht commented Aug 28, 2024

in csrc/flash_attn/src/utils.h
tensor(i) = cutlass::fast_tanh(tensor(i) * softcap);
Should it be rewritten as tensor(i) = cutlass::fast_tanh(tensor(i)) * softcap;?
@tridao
Copy link
Contributor

tridao commented Aug 28, 2024

No, you can see the original discussion in the PR
#1025 (comment)

@alex-ht
Copy link
Author

alex-ht commented Aug 28, 2024 •
edited
Loading

thanks!

@alex-ht alex-ht closed this as completed Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tridao @alex-ht