Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLAYBACK_METADATA_LOADED is documented twice #3977

Closed
paulhiggs opened this issue Jul 1, 2022 · 1 comment · Fixed by #3978
Closed

PLAYBACK_METADATA_LOADED is documented twice #3977

paulhiggs opened this issue Jul 1, 2022 · 1 comment · Fixed by #3978
Assignees
@dsilhavy
Labels
Bug
Milestone
4.4.1

Comments

@paulhiggs
Copy link

The PLAYBACK_METADATA_LOADED event is described twice in https://cdn.dashjs.org/latest/jsdoc/MediaPlayerEvents.html.
Most likely the second, for streaming/MediaPlayerEvents.js, line 290 should be for PLAYBACK_LOADED_DATA
@paulhiggs paulhiggs added the Bug label Jul 1, 2022
@dsilhavy dsilhavy added this to the 4.4.1 milestone Jul 4, 2022
@dsilhavy dsilhavy self-assigned this Jul 4, 2022
@dsilhavy dsilhavy mentioned this issue Jul 4, 2022
Merged
@dsilhavy
Copy link
Collaborator

dsilhavy commented Jul 4, 2022

Thanks, fixed in #3978

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsilhavy dsilhavy

Labels
Bug
Projects
None yet
Milestone
4.4.1
Development

Successfully merging a pull request may close this issue.

Fix wrong description of PLAYBACK_LOADED_DATA event Dash-Industry-Forum/dash.js
2 participants
@dsilhavy @paulhiggs