Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom (enterprise) domains in site configuration variable #2456

Open
inhearst opened this issue Mar 28, 2024 · 2 comments
Open
Labels
kind/feature-request Feature request related issue stale Stale - Bot reminder

Comments

@inhearst
Copy link

Is your feature request related to a problem? Please describe.
I use Datadog under an enterprise domain (like xxx.datadoghq.com) but it does not seem like I can set the URL in the configuration to this. I am able to use the Ruby API with this URL and it works correctly. Same as #1913 but it was closed for some reason.

Describe the solution you'd like
Ability to set the site and similar variables to our custom domain.

Describe alternatives you've considered
I can use another language, however a package I want to use (DD query parser) is only available in golang.

Additional context
Error info:

% go run main.go
Error when calling `MetricsApi.ListMetricAssets`: the variable site in the server URL has invalid value xxx.datadoghq.com. Must be [datadoghq.com us3.datadoghq.com us5.datadoghq.com ap1.datadoghq.com datadoghq.eu ddog-gov.com]
Full HTTP response: <nil>
Response from `MetricsApi.ListMetricAssets`:
{}
@inhearst inhearst added the kind/feature-request Feature request related issue label Mar 28, 2024
@therve
Copy link
Contributor

therve commented Mar 29, 2024

Hi,

Note that you should be able to use regular domain names for your organization, you don't have to use the custom. If you do, you need to set the ContextServerIndex context variable:

	ctx := datadog.NewDefaultContext(context.Background())
	ctx = context.WithValue(ctx, datadog.ContextServerIndex, 1)
	ctx = context.WithValue(ctx, datadog.ContextServerVariables,
		map[string]string{"name": "abc.datadoghq.com"},
	)

Let me know if that works for you.

Copy link

Thanks for your contribution!

This issue has been automatically marked as stale because it has not had activity in the last 30 days. Note that the issue will not be automatically closed, but this notification will remind us to investigate why there's been inactivity. Thank you for participating in the Datadog open source community.

If you would like this issue to remain open:

  1. Verify that you can still reproduce the issue in the latest version of this project.

  2. Comment that the issue is still reproducible and include updated details requested in the issue template.

@github-actions github-actions bot added the stale Stale - Bot reminder label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request Feature request related issue stale Stale - Bot reminder
Projects
None yet
Development

No branches or pull requests

2 participants