Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add time measurement with a func callback #68

Open
grosser opened this issue Nov 2, 2018 · 2 comments · May be fixed by #149
Open

add time measurement with a func callback #68

grosser opened this issue Nov 2, 2018 · 2 comments · May be fixed by #149
Labels
help wanted

Comments

@grosser
Copy link
Contributor

grosser commented Nov 2, 2018

func Time(name, fn func()) that reports how long something took

... I can make a PR for it unless there is a reason this is not wanted @truthbk ...
@arbll
Copy link
Member

arbll commented Nov 28, 2019

Hi @grosser,

I don't see anything wrong with doing this apart from a probable performance hit. Feel free to open a PR if you are still interested.

Arthur

@grosser grosser linked a pull request May 24, 2020 that will close this issue
Open
@cyberhck
Copy link

I'd love this, most of the time we're measuring time anyway, so having a utility function like this would help a lot 🙂

any idea if that PR will be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add Time function to report time a passed function takes grosser/datadog-go
3 participants
@grosser @cyberhck @arbll