Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new kube-state-metrics Helm chart #307

Closed
tokyowizard opened this issue Jul 8, 2021 · 2 comments · Fixed by #309
Closed

Use new kube-state-metrics Helm chart #307

tokyowizard opened this issue Jul 8, 2021 · 2 comments · Fixed by #309
Labels
chart/datadog This issue or pull request is related to the datadog chart

Comments

@tokyowizard
Copy link

As reported in #151, the KSM helm chart moved. But the KSM helm chart has moved yet again!

The current requirements.yaml is pointing to the version, 2.13.2, of the KSM helm chart that specifies KSM version 1.9.8. The new location of the KSM helm chart is here.

We'd like to be on KSM version 2+ because:

@clamoriniere clamoriniere added the chart/datadog This issue or pull request is related to the datadog chart label Jul 8, 2021
@clamoriniere
Copy link
Collaborator

Hello,

Thanks for opening this issue.

We are aware of this new move :) We have plan to use the new repo and the version 2.13.2. But it is not a real urgence since no new ksm v1.9.x as been released yet.

But, we will not update this dependency on any major version (3.x.x) for 2 reasons:

  • the kubernetes_state check is only compatible with kube-state-metrics v1.x.x, so keeping the kube-state-metrics chart version to v2.13.2. allow use to use the image version 1.9.8. This is to keep the metrics backward compatibility for user.
  • the new kubernetes_state_core check is base and it expose the new KSM 2+ metrics, but doesn't require to deploy kube-state-metrics chart (more info in this blog post).
    So if you plan to use the new check, you should not worry anymore about deploying and updating the kube-state-metrics chart with the datadog chart.

the proper way to do so is to add the following configuration in your values.yaml file:

datadog:
  # disable kube-state-metrics nested chart
  kubeStateMetricsEnabled: false
  # enable the new `kubernetes_state_core` check
  kubeStateMetricsCore:
    enabled: true

It will:

  • uninstall (during an upgrade) or not install the kube-state-metrics chart.
  • enable the kubernetes_state_core check.
  • disable the autodiscovery of the kubernetes_state check. So if you would like to deploy on your own kube-state-metrics on the same cluster, it will not trigger the auto-discovery and the execution of the kubernetes_state check.

Please let us know if I answered to your question, and if the solution that we propose works for you.

Cheers
Cedric

@clamoriniere
Copy link
Collaborator

Please reopen the issue, it you need more information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart/datadog This issue or pull request is related to the datadog chart
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants