Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is ComponentStatuses RBAC desirable? #961

Open
Bhutania opened this issue Mar 21, 2023 · 8 comments
Open

Is ComponentStatuses RBAC desirable? #961

Bhutania opened this issue Mar 21, 2023 · 8 comments
Labels
chart/datadog This issue or pull request is related to the datadog chart question Further information is requested

Comments

@Bhutania
Copy link

Describe what happened:
This is more a question than an issue, but I was going through a k8s cluster upgrade and noticed that there were deprecated resources still in these charts. While compenentstatuses are still technically in support (as a part of the v1 spec), they have been deprecated since v1.19+ as noted here: kubernetes/kubernetes#93570. Would it be appropriate to remove this resource from the RBAC list?

@nscherer-chipotle
Copy link

Chiming in that our tooling is also reporting this use of the deprecated API. Are there plans to migrate to another API?

@clamoriniere clamoriniere added chart/datadog This issue or pull request is related to the datadog chart question Further information is requested labels Jul 28, 2023
@clamoriniere
Copy link
Collaborator

clamoriniere commented Jul 28, 2023

Hi @Bhutania and @nscherer-chipotle

Thanks to both of you for opening this discussion.

For now, the datadog helm-chart still needs to be compatible with kubernetes version <= 1.19 so the RBAC is still needed.

Also it should not be an issue to request RBAC for resources that are not anymore available on the API Server.

About the middle/long term plan, Kubernetes doesn't plan to provide an equivalent Resources, but instead each control-plan component is exposing new SLIS metrics that can replace componentstatuses: https://kubernetes.io/docs/reference/instrumentation/slis/
Thanks to these new metrics, Datadog should be able to provide an easy migration path for user relying on control plan components heath service checks.

@Bhutania and @nscherer-chipotle: does the tooling that you are using to detect deprecated RBAC, is blocking the Datadog chart deployment?

@nscherer-chipotle
Copy link

In my case, no, it isn't blocking, this is just something built-in to Azure Kubernetes Service.

@Bhutania
Copy link
Author

Hi @clamoriniere

Apologies for the late reply,

In my case it also isn't blocking deployments, I just noticed that the api was being queried when running an update and was trying to isolate sources.

Is there a timeline as to when support for these older versions of k8s will be dropped? From what I see online: https://kubernetes.io/releases/
These versions are not even supported by the Kubernetes Project anymore. I'm not a contributor/maintainer so the decision lies with you and your team, but it would be convenient for these values to be removed.

Thanks,
Arnav

@MaryamTavakkoli
Copy link

Hi,
Any new update on this issue?

@peterezetta
Copy link

Any updates here? This has become a blocking issue for me with Kubernetes deploys of K8s 1.26+

@clamoriniere

@isaacegglestone
Copy link

isaacegglestone commented Mar 5, 2024

@clamoriniere I get that this actually hasn't been removed, so technically it still should work in 1.29, however it does kind of beg the question, that if your using a cluster version so old the cloud providers don't even support it anymore do we really need it in the code anymore at this point. (Your actually forced to upgrade on the cloud basically) I get there are bare metal clusters out there but can't they just use an older version of the DD helm chart until they manage to upgrade their clusters?

Or is it the new code isn't ready yet as there has been no real decision from k8s team to which release this will actually be removed in? (I mean I could understand other features are taking priority if their appears to still be no cut off date.)

https://kubernetes.io/docs/reference/kubernetes-api/cluster-resources/component-status-v1/

@vigohe
Copy link

vigohe commented Jun 12, 2024

Any updates? Azure warned us with this message

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart/datadog This issue or pull request is related to the datadog chart question Further information is requested
Projects
None yet
Development

No branches or pull requests

7 participants