-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: origin detection with container ID field (dogstatsd 1.2) #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmed-mez
force-pushed
the
ahmed/dsd-1.2
branch
4 times, most recently
from
March 11, 2022 12:05
03deab7
to
7c23cbe
Compare
ahmed-mez
force-pushed
the
ahmed/dsd-1.2
branch
from
March 11, 2022 12:14
7c23cbe
to
1705a9d
Compare
vickenty
reviewed
Mar 11, 2022
Thank you for the review @vickenty ! I'll try to address the comments soon 👍 |
ahmed-mez
force-pushed
the
ahmed/dsd-1.2
branch
from
March 11, 2022 15:20
b85c633
to
b5d5c8b
Compare
ahmed-mez
force-pushed
the
ahmed/dsd-1.2
branch
from
March 11, 2022 15:50
b5d5c8b
to
aa2f273
Compare
vickenty
reviewed
Mar 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but if possible let's tighten visibility on the new items.
ahmed-mez
force-pushed
the
ahmed/dsd-1.2
branch
from
March 18, 2022 12:39
d8458c0
to
2866eb1
Compare
vickenty
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
c:<id>
field holding the container ID so the agent can attach container tags.Description of the Change
DD_ENTITY_ID
is set, we ignore the container fieldDD_ENTITY_ID
is not set andDD_ORIGIN_DETECTION_ENABLED
is not explicitly set to false and theoriginDetectionEnabled
param is not explicitly disabled, we try to get the app container ID by parsing/proc/self/cgroup
. In case of success, the container field in will be set.Verification Process
Wrote a small app importing the lib and sending metrics to agent 7.35 with origin detection client enabled - the metrics were tagged with container tags.
Additional Notes