Updated Service Check to send constant tags #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sending constant tags
|
Thanks a lot @PatrickAuld we'll review shortly. |
|
Thank you for your contribution @PatrickAuld. I am merging your PR, so we can release a V2.1.1 soon 💥 |
yannmh
added a commit
that referenced
this pull request
Apr 27, 2015
Updated Service Check to send constant tags
|
No problem, we needed it. I'm looking forward to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ServiceCheck class doesn't reuse the tag serialization code within the Client which causes constance tags set on the client to not be included in the message. This moves the logic into the client and reuses the method that writes the messages and constant tags.