Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace String.format #49

Merged
merged 1 commit into from
May 17, 2018
Merged

Replace String.format #49

merged 1 commit into from
May 17, 2018

Conversation

cithal
Copy link

@cithal cithal commented Apr 23, 2018

We use NonBlockingStatsDClient.java in high throughput application. While profiling the application, we noticed that String.format is extremely inefficient and replacing String.format with StringBuilder without changing data format provides much better results.

Copy link
Contributor

@nmuesch nmuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for your contribution! This looks good to me so I'll go ahead and merge. This will be released in the next version of the client.

@nmuesch nmuesch merged commit 0e03131 into DataDog:master May 17, 2018
@nmuesch nmuesch added this to the 2.6 milestone May 17, 2018
@cithal
Copy link
Author

cithal commented Jun 21, 2018

Thanks @nmuesch. When can we expect next version of the client?

@nmuesch
Copy link
Contributor

nmuesch commented Jun 21, 2018

Hey @cithal There should be a new release of the client towards the end of next week.

@nmuesch
Copy link
Contributor

nmuesch commented Jul 2, 2018

Hey @cithal Just wanted to let you know that the Java Dogstatsd Client 2.6 released as of this past Friday!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants