Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS integration included regions #2304

Open
ggaugain opened this issue Mar 6, 2024 · 7 comments
Open

AWS integration included regions #2304

ggaugain opened this issue Mar 6, 2024 · 7 comments

Comments

@ggaugain
Copy link

ggaugain commented Mar 6, 2024

What resources or data sources are affected?

datadog_integration_aws

Feature Request

AWS regions to include from metrics collection.
The excluded_regions requires a list to be maintained and does not automatically exclude data collection on a new AWS region.

Example of usage:

resource "datadog_integration_aws" "sandbox" {
account_id = "1234567890"
role_name = "DatadogAWSIntegrationRole"
filter_tags = ["key:value"]
host_tags = ["key:value", "key2:value2"]
account_specific_namespace_rules = {
auto_scaling = false
opsworks = false
}
included_regions = ["us-east-1", "us-west-2"]
}

References

No response

@iniinikoski
Copy link

This would definitely make sense.

@hhughes0
Copy link

+1

1 similar comment
@ShaunKav
Copy link

+1

@knkcni
Copy link

knkcni commented Jul 23, 2024

would be a great way to deal with new regions

@danieljamesscott
Copy link

This would be great as we're currently getting perpetual drift trying to exclude the new ap-southeast-5 region. It seems to submit the request to datadog with no problem, but then a subsequent plan shows that the change has not been applied.

@fatbasstard
Copy link

fatbasstard commented Aug 30, 2024

Well, we just solve this inverted (Based on the regions from the OP):

locals {
  excluded_dd_regions = setsubtract(data.aws_regions.current.names, "us-east-1", "us-west-2")
}

data "aws_regions" "current" {
  all_regions = true
}

resource "datadog_integration_aws" "default" {
  excluded_regions                     = var.excluded_regions
}

@fatbasstard
Copy link

fatbasstard commented Aug 30, 2024

@danieljamesscott Noticed this as well. Created an issue for that behaviour: #2548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants