[graph-editor] Add support for WidgetCustomLink is_hidden and override_label properties
#1062
Conversation
| "override_label": { | ||
| Description: "The label id that refers to a context menu link item", | ||
| Type: schema.TypeString, | ||
| Optional: true, |
There was a problem hiding this comment.
Could not use ConflictsWith property here due to custom_link being in a list.
qincchen
changed the title
| Required: true, | ||
| Optional: true, | ||
| }, | ||
| "is_hidden": { |
There was a problem hiding this comment.
For the most part it looks good to me. The perpetual diff when both are set might be something we have to live with. Not sure of any viable/clean workarounds unless the rest of the team has any ideas. Could you also add a tests for the new fields please. Thanks
There was a problem hiding this comment.
@skarimo what causes the perpetual diff ?
There was a problem hiding this comment.
Chatted outside of the Github issue but to close the loop here, the perpetual diff is caused when both label and label_override is set.
We can keep the behavior as is but let's document that both fields should not be set at the same time.
Co-authored-by: skarimo <[email protected]>
Co-authored-by: skarimo <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
skarimo
changed the title
is_hidden and override_label properties
** Motivation
Terraform change to support new context menu link override functionality.
API spec change: https://github.com/DataDog/datadog-api-spec/pull/971/