Skip to content
This repository has been archived by the owner on Nov 7, 2023. It is now read-only.

Why are we parsing ourselves #24

Open
TyberiusPrime opened this issue Jul 13, 2023 · 2 comments
Open

Why are we parsing ourselves #24

TyberiusPrime opened this issue Jul 13, 2023 · 2 comments

Comments

@TyberiusPrime
Copy link
Contributor

There's probably a good reason that I don't know about,
but whey are we parsing like every sdist and wheel,
when we could ask the pypi json api - at least in the first place, with a fallback to 'parse it yourself'?

@DavHau
Copy link
Owner

DavHau commented Jul 14, 2023

I'm not sure to be honest. It's a while since I implemented this. It's possible that I missed something, or that the data we're interested in wasn't available at that time through the API. Feel free to improve it.

@InLaw
Copy link
Contributor

InLaw commented Jul 14, 2023

I hope I'm not totally wrong ..
wasn't a reason that the meta/data was/is not equal?

https://github.com/posativ/isso/blob/0.12.6.2/setup.py#L46
vs
https://pypi.org/pypi/isso/0.12.6.2/json # without install_requires

e.g.
"xlsxwriter (>=1.4.3) ; extra == 'all'" # would need a different parser?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants