Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize coding style #2

Open
DavidJCobb opened this issue Oct 28, 2020 · 0 comments
Open

Modernize coding style #2

DavidJCobb opened this issue Oct 28, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@DavidJCobb
Copy link
Owner

  • Prefer standard types like uint32_t over the MacOS-inspired xSE types like UInt32
  • Continue to use CamelCaseWithInitialCaps class and method names for consistency with Bethesda
  • xSE class definitions list multiple-inheritance parents as members, but since we're building with MSVC just as Bethesda did, this should not be necessary. For all RE definitions, undo the change and represent classes as Bethesda originally defined them. Use static asserts to guard against future breakage.
@DavidJCobb DavidJCobb added the enhancement New feature or request label Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DavidJCobb