From 4d31608e56af8e8e6c70a8ecf9935b0bdac16612 Mon Sep 17 00:00:00 2001
From: kennySix <1512613@student.hcmus.edu.vn>
Date: Mon, 30 Dec 2019 20:38:44 +0700
Subject: [PATCH 1/3] [#135] Adding github link to Logo

- On hover on the logo JD will make it change to colorAccent.
- On click to logo JD will also do the same, and redirect to this github
link.
---
 views/components/nav/NavLogo.js | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/views/components/nav/NavLogo.js b/views/components/nav/NavLogo.js
index 25619d1e..75d8d962 100644
--- a/views/components/nav/NavLogo.js
+++ b/views/components/nav/NavLogo.js
@@ -2,7 +2,7 @@ import * as React from 'react'
 import styled from 'styled-components/macro'
 
 const NavLogo = () => (
-  <Logo>
+  <Logo href="https://github.com/DeKal">
     <LogoText>JD</LogoText>
   </Logo>
 )
@@ -36,6 +36,15 @@ const Logo = styled.a`
     border-left: 40px solid transparent;
     border-right: 40px solid transparent;
   }
+
+  &:hover {
+    color: ${props => props.theme.colors.colorDark};
+    text-decoration: none;
+  }
+
+  &:active {
+    color: ${props => props.theme.colors.colorDark};
+  }
 `
 
 const LogoText = styled.span`

From 17ba58dd26b61dae3f5c07fbde88dde0b1bf1f64 Mon Sep 17 00:00:00 2001
From: Phat Ho <hhphat@apcs.vn>
Date: Mon, 30 Dec 2019 21:57:29 +0700
Subject: [PATCH 2/3] Fixing Snapshot

---
 .../__snapshots__/Navbar.spec.tsx.snap        | 16 +++++++---
 .../__snapshots__/NavContent.spec.tsx.snap    | 32 ++++++++++++++-----
 .../__snapshots__/NavLogo.spec.tsx.snap       |  4 ++-
 3 files changed, 39 insertions(+), 13 deletions(-)

diff --git a/views/components/__test__/__snapshots__/Navbar.spec.tsx.snap b/views/components/__test__/__snapshots__/Navbar.spec.tsx.snap
index ad6bc5e3..6d509147 100644
--- a/views/components/__test__/__snapshots__/Navbar.spec.tsx.snap
+++ b/views/components/__test__/__snapshots__/Navbar.spec.tsx.snap
@@ -673,7 +673,9 @@ exports[`Navbar should render without throwing an error 1`] = `
                                 className="col-md-2"
                               >
                                 <NavLogo>
-                                  <NavLogo__Logo>
+                                  <NavLogo__Logo
+                                    href="https://github.com/DeKal"
+                                  >
                                     <StyledComponent
                                       forwardedComponent={
                                         Object {
@@ -682,7 +684,7 @@ exports[`Navbar should render without throwing an error 1`] = `
                                           "componentStyle": ComponentStyle {
                                             "componentId": "NavLogo__Logo-sc-1822jsu-0",
                                             "isStatic": false,
-                                            "lastClassName": "IYNu",
+                                            "lastClassName": "hsWCem",
                                             "rules": Array [
                                               "display:block;position:absolute;width:",
                                               [Function],
@@ -698,7 +700,11 @@ exports[`Navbar should render without throwing an error 1`] = `
                                               [Function],
                                               ";border:none;@media screen and (max-width:800px){display:none;}&::after{content:'';position:absolute;bottom:-29px;left:0;z-index:250;border-top:30px solid ",
                                               [Function],
-                                              ";border-left:40px solid transparent;border-right:40px solid transparent;}",
+                                              ";border-left:40px solid transparent;border-right:40px solid transparent;}&:hover{color:",
+                                              [Function],
+                                              ";text-decoration:none;}&:active{color:",
+                                              [Function],
+                                              ";}",
                                             ],
                                           },
                                           "displayName": "NavLogo__Logo",
@@ -712,9 +718,11 @@ exports[`Navbar should render without throwing an error 1`] = `
                                         }
                                       }
                                       forwardedRef={null}
+                                      href="https://github.com/DeKal"
                                     >
                                       <a
-                                        className="NavLogo__Logo-sc-1822jsu-0 IYNu"
+                                        className="NavLogo__Logo-sc-1822jsu-0 hsWCem"
+                                        href="https://github.com/DeKal"
                                       >
                                         <NavLogo__LogoText>
                                           <StyledComponent
diff --git a/views/components/nav/__test__/__snapshots__/NavContent.spec.tsx.snap b/views/components/nav/__test__/__snapshots__/NavContent.spec.tsx.snap
index aaba6f86..436256fa 100644
--- a/views/components/nav/__test__/__snapshots__/NavContent.spec.tsx.snap
+++ b/views/components/nav/__test__/__snapshots__/NavContent.spec.tsx.snap
@@ -99,7 +99,9 @@ exports[`Nav Content should render with isShowNavContent disable 1`] = `
                         className="col-md-2"
                       >
                         <NavLogo>
-                          <NavLogo__Logo>
+                          <NavLogo__Logo
+                            href="https://github.com/DeKal"
+                          >
                             <StyledComponent
                               forwardedComponent={
                                 Object {
@@ -108,7 +110,7 @@ exports[`Nav Content should render with isShowNavContent disable 1`] = `
                                   "componentStyle": ComponentStyle {
                                     "componentId": "NavLogo__Logo-sc-1822jsu-0",
                                     "isStatic": false,
-                                    "lastClassName": "IYNu",
+                                    "lastClassName": "hsWCem",
                                     "rules": Array [
                                       "display:block;position:absolute;width:",
                                       [Function],
@@ -124,7 +126,11 @@ exports[`Nav Content should render with isShowNavContent disable 1`] = `
                                       [Function],
                                       ";border:none;@media screen and (max-width:800px){display:none;}&::after{content:'';position:absolute;bottom:-29px;left:0;z-index:250;border-top:30px solid ",
                                       [Function],
-                                      ";border-left:40px solid transparent;border-right:40px solid transparent;}",
+                                      ";border-left:40px solid transparent;border-right:40px solid transparent;}&:hover{color:",
+                                      [Function],
+                                      ";text-decoration:none;}&:active{color:",
+                                      [Function],
+                                      ";}",
                                     ],
                                   },
                                   "displayName": "NavLogo__Logo",
@@ -138,9 +144,11 @@ exports[`Nav Content should render with isShowNavContent disable 1`] = `
                                 }
                               }
                               forwardedRef={null}
+                              href="https://github.com/DeKal"
                             >
                               <a
-                                className="NavLogo__Logo-sc-1822jsu-0 IYNu"
+                                className="NavLogo__Logo-sc-1822jsu-0 hsWCem"
+                                href="https://github.com/DeKal"
                               >
                                 <NavLogo__LogoText>
                                   <StyledComponent
@@ -1012,7 +1020,9 @@ exports[`Nav Content should render with isShowNavContent enable 1`] = `
                         className="col-md-2"
                       >
                         <NavLogo>
-                          <NavLogo__Logo>
+                          <NavLogo__Logo
+                            href="https://github.com/DeKal"
+                          >
                             <StyledComponent
                               forwardedComponent={
                                 Object {
@@ -1021,7 +1031,7 @@ exports[`Nav Content should render with isShowNavContent enable 1`] = `
                                   "componentStyle": ComponentStyle {
                                     "componentId": "NavLogo__Logo-sc-1822jsu-0",
                                     "isStatic": false,
-                                    "lastClassName": "IYNu",
+                                    "lastClassName": "hsWCem",
                                     "rules": Array [
                                       "display:block;position:absolute;width:",
                                       [Function],
@@ -1037,7 +1047,11 @@ exports[`Nav Content should render with isShowNavContent enable 1`] = `
                                       [Function],
                                       ";border:none;@media screen and (max-width:800px){display:none;}&::after{content:'';position:absolute;bottom:-29px;left:0;z-index:250;border-top:30px solid ",
                                       [Function],
-                                      ";border-left:40px solid transparent;border-right:40px solid transparent;}",
+                                      ";border-left:40px solid transparent;border-right:40px solid transparent;}&:hover{color:",
+                                      [Function],
+                                      ";text-decoration:none;}&:active{color:",
+                                      [Function],
+                                      ";}",
                                     ],
                                   },
                                   "displayName": "NavLogo__Logo",
@@ -1051,9 +1065,11 @@ exports[`Nav Content should render with isShowNavContent enable 1`] = `
                                 }
                               }
                               forwardedRef={null}
+                              href="https://github.com/DeKal"
                             >
                               <a
-                                className="NavLogo__Logo-sc-1822jsu-0 IYNu"
+                                className="NavLogo__Logo-sc-1822jsu-0 hsWCem"
+                                href="https://github.com/DeKal"
                               >
                                 <NavLogo__LogoText>
                                   <StyledComponent
diff --git a/views/components/nav/__test__/__snapshots__/NavLogo.spec.tsx.snap b/views/components/nav/__test__/__snapshots__/NavLogo.spec.tsx.snap
index 7b204115..b65632af 100644
--- a/views/components/nav/__test__/__snapshots__/NavLogo.spec.tsx.snap
+++ b/views/components/nav/__test__/__snapshots__/NavLogo.spec.tsx.snap
@@ -1,7 +1,9 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`Nav Logo should render without throwing an error 1`] = `
-<NavLogo__Logo>
+<NavLogo__Logo
+  href="https://github.com/DeKal"
+>
   <NavLogo__LogoText>
     JD
   </NavLogo__LogoText>

From d13dfbc0542bd0002fdd30a61909b92dded9a6f8 Mon Sep 17 00:00:00 2001
From: kennySix <1512613@student.hcmus.edu.vn>
Date: Mon, 30 Dec 2019 22:11:52 +0700
Subject: [PATCH 3/3] [135] Adding github link to Logo

Adding github link to Logo #135
---
 .../__test__/__snapshots__/Navbar.spec.tsx.snap      |  6 +++---
 views/components/nav/NavLogo.js                      |  2 +-
 .../__test__/__snapshots__/NavContent.spec.tsx.snap  | 12 ++++++------
 .../nav/__test__/__snapshots__/NavLogo.spec.tsx.snap |  2 +-
 4 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/views/components/__test__/__snapshots__/Navbar.spec.tsx.snap b/views/components/__test__/__snapshots__/Navbar.spec.tsx.snap
index 6d509147..eddac2e3 100644
--- a/views/components/__test__/__snapshots__/Navbar.spec.tsx.snap
+++ b/views/components/__test__/__snapshots__/Navbar.spec.tsx.snap
@@ -674,7 +674,7 @@ exports[`Navbar should render without throwing an error 1`] = `
                               >
                                 <NavLogo>
                                   <NavLogo__Logo
-                                    href="https://github.com/DeKal"
+                                    href="https://github.com/DeKal/portfolio-next-js"
                                   >
                                     <StyledComponent
                                       forwardedComponent={
@@ -718,11 +718,11 @@ exports[`Navbar should render without throwing an error 1`] = `
                                         }
                                       }
                                       forwardedRef={null}
-                                      href="https://github.com/DeKal"
+                                      href="https://github.com/DeKal/portfolio-next-js"
                                     >
                                       <a
                                         className="NavLogo__Logo-sc-1822jsu-0 hsWCem"
-                                        href="https://github.com/DeKal"
+                                        href="https://github.com/DeKal/portfolio-next-js"
                                       >
                                         <NavLogo__LogoText>
                                           <StyledComponent
diff --git a/views/components/nav/NavLogo.js b/views/components/nav/NavLogo.js
index 75d8d962..388e7edf 100644
--- a/views/components/nav/NavLogo.js
+++ b/views/components/nav/NavLogo.js
@@ -2,7 +2,7 @@ import * as React from 'react'
 import styled from 'styled-components/macro'
 
 const NavLogo = () => (
-  <Logo href="https://github.com/DeKal">
+  <Logo href="https://github.com/DeKal/portfolio-next-js">
     <LogoText>JD</LogoText>
   </Logo>
 )
diff --git a/views/components/nav/__test__/__snapshots__/NavContent.spec.tsx.snap b/views/components/nav/__test__/__snapshots__/NavContent.spec.tsx.snap
index 436256fa..6c272ec7 100644
--- a/views/components/nav/__test__/__snapshots__/NavContent.spec.tsx.snap
+++ b/views/components/nav/__test__/__snapshots__/NavContent.spec.tsx.snap
@@ -100,7 +100,7 @@ exports[`Nav Content should render with isShowNavContent disable 1`] = `
                       >
                         <NavLogo>
                           <NavLogo__Logo
-                            href="https://github.com/DeKal"
+                            href="https://github.com/DeKal/portfolio-next-js"
                           >
                             <StyledComponent
                               forwardedComponent={
@@ -144,11 +144,11 @@ exports[`Nav Content should render with isShowNavContent disable 1`] = `
                                 }
                               }
                               forwardedRef={null}
-                              href="https://github.com/DeKal"
+                              href="https://github.com/DeKal/portfolio-next-js"
                             >
                               <a
                                 className="NavLogo__Logo-sc-1822jsu-0 hsWCem"
-                                href="https://github.com/DeKal"
+                                href="https://github.com/DeKal/portfolio-next-js"
                               >
                                 <NavLogo__LogoText>
                                   <StyledComponent
@@ -1021,7 +1021,7 @@ exports[`Nav Content should render with isShowNavContent enable 1`] = `
                       >
                         <NavLogo>
                           <NavLogo__Logo
-                            href="https://github.com/DeKal"
+                            href="https://github.com/DeKal/portfolio-next-js"
                           >
                             <StyledComponent
                               forwardedComponent={
@@ -1065,11 +1065,11 @@ exports[`Nav Content should render with isShowNavContent enable 1`] = `
                                 }
                               }
                               forwardedRef={null}
-                              href="https://github.com/DeKal"
+                              href="https://github.com/DeKal/portfolio-next-js"
                             >
                               <a
                                 className="NavLogo__Logo-sc-1822jsu-0 hsWCem"
-                                href="https://github.com/DeKal"
+                                href="https://github.com/DeKal/portfolio-next-js"
                               >
                                 <NavLogo__LogoText>
                                   <StyledComponent
diff --git a/views/components/nav/__test__/__snapshots__/NavLogo.spec.tsx.snap b/views/components/nav/__test__/__snapshots__/NavLogo.spec.tsx.snap
index b65632af..a5699533 100644
--- a/views/components/nav/__test__/__snapshots__/NavLogo.spec.tsx.snap
+++ b/views/components/nav/__test__/__snapshots__/NavLogo.spec.tsx.snap
@@ -2,7 +2,7 @@
 
 exports[`Nav Logo should render without throwing an error 1`] = `
 <NavLogo__Logo
-  href="https://github.com/DeKal"
+  href="https://github.com/DeKal/portfolio-next-js"
 >
   <NavLogo__LogoText>
     JD