-
Notifications
You must be signed in to change notification settings - Fork 86
Error when building on OS X 10.12.6 #20
Comments
Which compiler are you using? Is it capable of c++ 17? Is it using the latest version? "/Users/eujingoh/waifu2x-converter-cpp/src/main.cpp:20:10: fatal error: 'experimental/filesystem' file not found" |
If you just want it to work, you can but without the changes I PR'ed into it. Just get the version prior to me doing so. Using this sha1 d693130 or |
I'm using xcode which currently doesn't have support I tried the v4 release instead and it worked so there's that |
Did it give you any useful logs? If so could you send them to me. Oh, and could you also send the result of this |
I'm not currently at home so, you'll have to wait a while and, the only logs I got was what was built I also need to say I know nothing about programming |
this is all gcc -v gives
and this is the "log" when building from gcc
although I missed some information that I should say In order to even get to that stage for the current build I had to add to CMakeLists.txt otherwise I'd get a whole ton of errors and warnings then do cmake followed by make to get the 'experimental/filesystem' not found
it will complete but waifu2x executable will not be produced If I were to do cmake from gcc and to make immediately I'd get this As I said I have no knowledge of programming and have close to no idea what I'm doing |
|
Yeah, it looks like it doesn't build anymore on OSX. Switching to gcc seems to break opencv that comes with homebrew. I'll see what I can do. If anybody reading this wants to help, feel free to step forward. |
(I don't have a mac) |
If I'm not wrong Xcode 9 is still in beta... |
Could you try it anyhow? If we can compile using it we should be able to use those binaries on any capable mac device no? |
(wow I've been got for a while) I also don't know what you mean by
Do you want me to remove just those specific lines in main.cpp or remove the entire line? So |
True.
Like you showed in your example, here is what you should do.
into
and
into
|
With the latest XCode updates, simply by checking out d693130 and without doing any change, it works just fine again. I tried checking out head and making the changes in #issuecomment-336910126 but that errors out. |
@toyg what cmake version does macos use? Should be 3.8 or newer, just curious |
|
Can you run cmake with cmake .. -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON |
|
Edited by DeadSix (please use pastebin or so in the future): |
@toyg your cmake can't find opencv, can you make a fully clean sub folder, then run the following:
Then go into About the c++ issues, lets first figure the opencv thing out |
@toyg nvm you must have edited/updated your post, I assume you are on the newest version of the repo now? |
Yeah i did a clean checkout |
@toyg |
@toyg I wanna test something, in include/picojson.h, see line 47, there it says:
Change that to: |
@toyg ye I'm clueless.. Can't you get g++ on MacOS or cross compile to apple from linux (altho I do not think the cmake file supports that)? Ill add help wanted tag.. not that seems to attract many people considering every issue has that tag at this point :p |
I think I'm getting somewhere...
into
and renamed the file from "Headers" into "CL"
|
Try removing "stdc++fs" here: https://github.com/DeadSix27/waifu2x-converter-cpp/blob/master/CMakeLists.txt#L282 stdc++fs is g++ specific EDIT2: |
@xxprototypexx32 Make sure to read "EDIT2" @ above post |
gives
removing "stdc++fs" gives |
@xxprototypexx32 Can you try renaming every occurence of "stdc++" to "c++experimental" I saw that here: https://stackoverflow.com/a/45332844 I never really touched clang.. so idk what the clang equivalent for experimental::filesystem is and in what library it is. EDIT: There is also: https://stackoverflow.com/a/46385720 and https://stackoverflow.com/a/42634858 |
This is the log now
Do I remove the "fs" at the back or leave it there? |
Remove c++experimentalfs |
Sorry, what? I don't have any experience with coding so pardon me
So do I add it at the back like " stdc++ c++experimental" |
Try: "stdc++ c++experimental" if not work then try: "c++experimental" |
Alright pretty much the same results... |
Wait, even for "stdc++" ? (I mean does it say it can't find that one) And Idk then, someone with more experience on XCode/Clang etc would need to figure out how to use filesystem there.. |
Didn't the log show that when I posted for
|
@xxprototypexx32 Not really, it showed you lack stdc++fs, not stdc++. (Using just "stdc++" does that work?) |
No, it just shows "Undefined symbols for architecture x86_64" |
Did you build clang with: |
I installed with homebrew, there aren't any options for that |
http://formulae.brew.sh/repos/Homebrew/homebrew-core/formula/gcc Homebrew has gcc 7.2.0 Why are you not using that? (or would that be cross compiling? I literally have no idea how this works on apple) |
I used gcc on my second post in this thread |
Run again with gcc and use "-DCMAKE_VERBOSE_MAKEFILE:BOOL=ON" in cmake then post full output of cmake and make |
cmake rework latest build |
this issue seems like fixed, as you can see #131 , we have no problem building with OSX. |
Running OS X Sierra 10.12.6
All goes well until the "make" part, this just happens:
https://pastebin.com/m763EaME
Yes I do have the latest version of openCV installed
I have OpenCV 3.3.0 and Cmake 3.9 installed
The latest versions of both, what's wrong?
Edit 2:
I somehow managed to solve some of these problems and now I get this
https://pastebin.com/G0Nxrgbw
Though I think you should still look at the first log in case anyone else has the same problem and also because I may have done stuff wrongly
The text was updated successfully, but these errors were encountered: