-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to meshkernelpy 5.0.1 #702
Comments
Two testcases fail:
Reported in Deltares/MeshKernelPy#189. It can be easily solved by switching the expected values, but the new deletion behavior is counter-intuitive and might be a breaking change for some users. Therefore, this should be considered carefully. In my view, the best way to move forward is patching meshkernel(py) by reverting the deletion behaviour. |
This is resolved in meshkernel 5.0.1, released today |
What is the need for this task.
Major version of meshkernelpy was updated (to 5.0.0), hydrolib-core should be accomodated for this new version. It is the expectation that no code changes are needed.
What is the task?
Update minimum meshkernelpy version in pyproject.toml
Also, add testcase for
DeleteMeshOption.FACES_WITH_INCLUDED_CIRCUMCENTERS
The text was updated successfully, but these errors were encountered: