Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of type piracy on DataInterpolations for SparseConnectivityTracer #1733

Closed
SouthEndMusic opened this issue Aug 19, 2024 · 2 comments · Fixed by #1794
Closed

Get rid of type piracy on DataInterpolations for SparseConnectivityTracer #1733

SouthEndMusic opened this issue Aug 19, 2024 · 2 comments · Fixed by #1794
Labels
core Issues related to the computational core in Julia tech-debt Improvements related to technical debt

Comments

@SouthEndMusic
Copy link
Collaborator

#1606 introduces type piracy on DataInterpolations to create a custom overload of interpolation evaluation for SparseConnectivityTracer, see also the Aqua test. This can be removed when SparseConnectivityTracer introduces their own support for DataInterpolations, which they will probably do as indicated here.

@visr visr added core Issues related to the computational core in Julia tech-debt Improvements related to technical debt labels Aug 19, 2024
@adrhill
Copy link

adrhill commented Aug 20, 2024

We've got some shiny new doc-pages in SCT, including one on how to add overloads.

Feel free to open a PR with a SparseConnectivityTracerDataInterpolationsExt, even if it just implements the minimal set of functions you need. Let me know if things are unclear or if you need some help!

@SouthEndMusic
Copy link
Collaborator Author

@adrhill thanks for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues related to the computational core in Julia tech-debt Improvements related to technical debt
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants