Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect parsing of string that starts with "0Dxxxxx" #57

Closed
2 tasks done
xldeltares opened this issue Aug 11, 2023 · 0 comments · Fixed by #58
Closed
2 tasks done

Incorrect parsing of string that starts with "0Dxxxxx" #57

xldeltares opened this issue Aug 11, 2023 · 0 comments · Fixed by #58
Assignees
@xldeltares
Labels
bug Something isn't working

Comments

@xldeltares
Copy link
Collaborator

Version checks

  • I have checked that this issue has not already been reported.
  • I have checked that this bug exists on the latest version.

Reproducible Example

reproducible example is reported in Deltares/HYDROLIB-core#559

Current behaviour

When reading a model that has storagenodes with id "0D05252", the string is parsed incorrectly as "0e05252"

Desired behaviour

When reading a model that has storagenodes with id "0D05252", it should return "0D05252"

Additional context

The temporary fix can be removed once Deltares/HYDROLIB-core#559 is resolved.
@xldeltares xldeltares added the bug Something isn't working label Aug 11, 2023
@xldeltares xldeltares self-assigned this Aug 11, 2023
@xldeltares xldeltares mentioned this issue Aug 11, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xldeltares xldeltares

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Santacruz Deltares/hydromt_delft3dfm
1 participant
@xldeltares