Generated column spec is wrong

[antoineB]

According to postgres doc https://www.postgresql.org/docs/current/sql-createtable.html
The spec of GENERATED should not be:

      seq(
        optional(seq($.keyword_generated, $.keyword_always)),
        $.keyword_as,
        $._expression,
      ),

But

      seq(
        $.keyword_generated,
        choice(
          seq($.keyword_always, $.keyword_as, $.paren_list($._expression), $.keyword_stored),
          seq(
            choice(
              $.keyword_always,
              seq($.keyword_by, $.keyword_default)
            ),
            $.keyword_as,
            $.keyword_identity,
            optional($.paren_list($.sequence_options))
          ),
        ),
      ),

[matthias-Q]

I have not taken a very deep look into this for a long time, but keep in mind that this parser is aimed to be permissive. It should also support other dialects like MySQL, MariaDB and so on.

Do you get an error with a SQL statement while parsing?

[matthias-Q]

But you are right. I just tested some of the first examples of the Postgres documentation for create table and I get some parsing errors.