Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is:dupe should not count ITL weapons as duplicate from original #10321

Open
Revadike opened this issue Apr 10, 2024 · 4 comments
Open

is:dupe should not count ITL weapons as duplicate from original #10321

Revadike opened this issue Apr 10, 2024 · 4 comments

Comments

@Revadike
Copy link
Contributor

Revadike commented Apr 10, 2024

Proposed change

Adept and non-adept weapons share the same origin trait and perk pool. Their only difference is the adept weapon mod. And for crafted weapons vs non-crafted, their only difference is possible enhanced perks. I'm glad they are counted as dupe, as they should.

These reprised weapons from ITL are mostly wildly different, though, as opposed to their original counterparts. They have different perk pools and different origin traits. I would not consider them the same/dupe. Therefore, is:dupe should not count them as such.

How does this fit into your workflow?

is:dupe is an important filter to me to decide what to dismantle, and this suggested change would more accurately reflect its intended meaning imo.

@robojumper
Copy link
Member

Linking #9906

@bhollis
Copy link
Contributor

bhollis commented May 21, 2024

I understand the complaint, but the difference should be readily apparent in the Compare page, right? You're not likely to get confused about which is which.

@Revadike
Copy link
Contributor Author

It confuses my junk filter

@Revadike
Copy link
Contributor Author

Revadike commented Sep 6, 2024

Maybe is:exactdupe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants