Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Armory should not show wishlist thumbs on perks #10625

Open
Prometheus3375 opened this issue Jun 30, 2024 · 4 comments
Open

Armory should not show wishlist thumbs on perks #10625

Prometheus3375 opened this issue Jun 30, 2024 · 4 comments

Comments

@Prometheus3375
Copy link

Prometheus3375 commented Jun 30, 2024

DIM Version

Version (release), built on 24.06.2024, 05:03:47

Browser Details

Chrome 126.0.0.0

OS Details

Windows 10

Describe the bug

How to reproduce (probably)

  1. Open DIM.
  2. Click on a weapon with wishlisted roll.
    image
  3. Open its weapon card.
    image
  4. Close it.
  5. Open weapon card of other weapons.
    image
    image

Expected result

No marks on any perk displayed in a weapon card unless a perk is wishlisted.

Actual result

I do not wishlist Arrowhead Brake on Yarovit, but it is marked.
I do not have wishlists for Midha at all, but some perks are marked.

@bhollis
Copy link
Contributor

bhollis commented Jul 8, 2024

I don't actually understand why the perks are showing thumbs on the Armory page at all. That seems to be the bug.

@Prometheus3375
Copy link
Author

I was thinking the same way, but recently I noticed this is happening quite a lot, so at a time of creating this report I assumed they should display.

@BasicNullification
Copy link

Since wishlists are viewed top-down anyway, it'd actually be a nice to have feature to have the card highlight the absolute "god-roll" (which is simply the highest ranking roll for that item in the list). I manage my own personal Github wishlist as well as use the default and would like to have the capability to see my top preferred roll at a glance.

To add some emphasis, would even be nice to see top-tier rolls perhaps add a golden outline/overlay/glow/etc when the perks match the top-most listed item on the list exactly.

Maybe this should be its own FR.. But for all I know maybe this was the intention to begin with and perhaps this in itself is what's actually bugged, so it might fit here.

@bhollis
Copy link
Contributor

bhollis commented Jul 17, 2024

Yeah this is already captured in other issues. See the Feature: Wish List label.

@bhollis bhollis changed the title Perks inside Weapon Cards are marked as wishlisted even if there is no wishlist with such perks Armory should not show wishlist thumbs on perks Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants