Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect magazine size listed for Rapid Fire snipers (listed as 5, is actually 6 in game) #5926

Closed
JosephBono opened this issue Sep 29, 2020 · 1 comment
Closed

Incorrect magazine size listed for Rapid Fire snipers (listed as 5, is actually 6 in game) #5926

JosephBono opened this issue Sep 29, 2020 · 1 comment
Labels
Bug

Comments

@JosephBono
Copy link

What version of DIM are you using?
Issue occurs on latest version of Beta and release
Beta: Version 6.32.0.8569 (beta), built on 9/29/2020, 9:58:43 AM
Release: Version 6.32.0 (release), built on 9/27/2020, 5:06:17 PM

What Browser and OS are you using?
Google Chrome (Version 85.0.4183.121 (Official Build) (64-bit)) on Windows 10 Pro 1909, Build 18363.1082

Describe the bug and how to make it happen
This may be a data bug from the Bungie API.

The magazine ammo count for rapid fire snipers is calculated incorrectly when there are no mods or magazine perks selected that change the base magazine size. In game a rapid fire sniper with no magazine size increase will have a magazine size of 6. In DIM it will be displayed with a value of 5.

Repro: in game pull a Tongeren-LR3 blue sniper rifle from collections (Y1 or Y2). Inspect it in game and see that the magazine size is listed as 6 and it holds 6 bullets when equipped. In DIM inspect the weapon and see that DIM lists it as having a magazine size of 5. Bug repros for any Rapid Fire frame sniper rifle without a magazine size altering perk or mod.

I have not noted any other weapon archetypes that have miscalculated magazine sizes.

This bug only started appearing recently (I want to say it was getting the correct number a week ago).

I have seen the same issue occur in D2Gunsmith, so the root cause may be bad data coming from the Bungie API.

Include devtools console logs
If you can, open the devtools console (ctrl+shift+J on PC and cmd+option+J on Mac) and paste what you see in the window that pops up:

Issues detected. The new Issues tab displays information about deprecations, breaking changes and other potential problems.Go to IssuesLearn more
instrument.ts:129 DIM v6.32.0.8569 (beta) - Please report any errors to https://www.github.com/DestinyItemManager/DIM/issues
instrument.ts:129 Load accounts from IDB
instrument.ts:129 globalSettings Object
instrument.ts:129 Discarded 9150 duplicate rolls from wish list
(anonymous) @ instrument.ts:129
wishlist-file.ts:72 Parse wish list: 209.28515625 ms
instrument.ts:129 Saving profile data to IDB
manifest-service-json.ts:141 Load manifest: 6947.727783203125 ms
instrument.ts:129 Sucessfully stored manifest file.
d2-stores.ts:234 Process inventory: 113.033935546875 ms
d2-stores.ts:238 Inventory state update: 745.6279296875 ms
instrument.ts:129 Object
d2-stores.ts:234 Process inventory: 183.3271484375 ms
d2-stores.ts:238 Inventory state update: 242.603271484375 ms
instrument.ts:129 Object
instrument.ts:129 Object
instrument.ts:129 Object
instrument.ts:129 Saving profile data to IDB
reducer.ts:444 prepareUpdateQueue: 1.441162109375 ms
instrument.ts:129 [flushUpdates] Flushing queue of 1 updates
instrument.ts:129 [flushUpdates] got results Array(1) Array(1)
instrument.ts:129 Saving profile data to IDB
instrument.ts:129 Object
instrument.ts:129 Object
instrument.ts:129 Object
instrument.ts:129 Object
instrument.ts:129 Object
instrument.ts:129 Invalid query term basestat cus Error: Missing range comparison
    at i (range-numeric.tsx:10)
    at B (stats.tsx:99)
    at Object.filter (stats.tsx:29)
    at n (search-filter.ts:131)
    at search-filter.ts:146
    at search-filter.ts:51
    at index.js:70
    at index.js:30
    at index.js:84
    at index.js:30
    at Function.mapToProps (ConnectedInventoryItem.tsx:45)
    at r (wrapMapToProps.js:41)
    at selectorFactory.js:44
    at selectorFactory.js:63
    at e.d (connectAdvanced.js:64)
    at e.handleChangeWrapper (Subscription.js:97)
    at Subscription.js:23
    at is (react-dom.production.min.js:240)
    at Object.notify (Subscription.js:19)
    at e.notifyNestedSubs (Subscription.js:92)
    at e.d (connectAdvanced.js:77)
    at e.handleChangeWrapper (Subscription.js:97)
    at Subscription.js:23
    at is (react-dom.production.min.js:240)
    at Object.notify (Subscription.js:19)
    at e.notifyNestedSubs (Subscription.js:92)
    at e.d (connectAdvanced.js:77)
    at e.handleChangeWrapper (Subscription.js:97)
    at Subscription.js:23
    at is (react-dom.production.min.js:240)
    at Object.notify (Subscription.js:19)
    at e.notifyNestedSubs (Subscription.js:92)
    at e.d (connectAdvanced.js:77)
    at e.handleChangeWrapper (Subscription.js:97)
    at Subscription.js:23
    at is (react-dom.production.min.js:240)
    at Object.notify (Subscription.js:19)
    at e.notifyNestedSubs (Subscription.js:92)
    at e.d (connectAdvanced.js:77)
    at e.handleChangeWrapper (Subscription.js:97)
    at Subscription.js:23
    at is (react-dom.production.min.js:240)
    at Object.notify (Subscription.js:19)
    at e.notifyNestedSubs (Subscription.js:92)
    at e.d (connectAdvanced.js:77)
    at e.handleChangeWrapper (Subscription.js:97)
    at Subscription.js:23
    at is (react-dom.production.min.js:240)
    at Object.notify (Subscription.js:19)
    at e.notifyNestedSubs (Subscription.js:92)
(anonymous) @ instrument.ts:129
instrument.ts:129 Saving profile data to IDB
reducer.ts:444 prepareUpdateQueue: 0.534912109375 ms
instrument.ts:129 [flushUpdates] Flushing queue of 1 updates
instrument.ts:129 [flushUpdates] got results Array(1) Array(1)
instrument.ts:129 Saving profile data to IDB
d2-stores.ts:234 Process inventory: 169.708984375 ms
d2-stores.ts:238 Inventory state update: 168.98779296875 ms
instrument.ts:129 Saving profile data to IDB
d2-stores.ts:234 Process inventory: 144.10400390625 ms
d2-stores.ts:238 Inventory state update: 157.77490234375 ms
instrument.ts:129 User initiated move: 1 Tranquility Kinetic to Human Female Titan from Awoken Female Warlock
instrument.ts:129 Move 1 Tranquility Kinetic to Vault from Awoken Female Warlock
instrument.ts:129 Move 1 Tranquility Kinetic to Human Female Titan from Vault
instrument.ts:129 User initiated move: 1 Atalanta-D XG1992 Kinetic to Human Female Titan from Awoken Female Warlock
instrument.ts:129 Move 1 Atalanta-D XG1992 Kinetic to Vault from Awoken Female Warlock
instrument.ts:129 Move 1 Atalanta-D XG1992 Kinetic to Human Female Titan from Vault
instrument.ts:129 User initiated move: 1 The Recluse Energy to Human Female Titan from Awoken Female Warlock
instrument.ts:129 Move 1 The Recluse Energy to Vault from Awoken Female Warlock
instrument.ts:129 Move 1 The Recluse Energy to Human Female Titan from Vault
instrument.ts:129 User initiated move: 1 Hard Light Energy to Human Female Titan from Awoken Female Warlock
instrument.ts:129 Move 1 Hard Light Energy to Vault from Awoken Female Warlock
instrument.ts:129 Move 1 Hard Light Energy to Human Female Titan from Vault
instrument.ts:129 User initiated move: 1 Pyroclastic Flow Power to Human Female Titan from Awoken Female Warlock
instrument.ts:129 Move 1 Pyroclastic Flow Power to Vault from Awoken Female Warlock
instrument.ts:129 Move 1 Pyroclastic Flow Power to Human Female Titan from Vault
instrument.ts:129 User initiated move: 1 Falling Guillotine Power to Human Female Titan from Awoken Female Warlock
instrument.ts:129 Move 1 Falling Guillotine Power to Vault from Awoken Female Warlock
instrument.ts:129 Move 1 Falling Guillotine Power to Human Female Titan from Vault
instrument.ts:129 Resetting lock status of Falling Guillotine to false when moving to Human Female Titan to work around Bungie.net lock state bug
instrument.ts:129 User initiated move: 1 Scorched Hunter Mask Helmet to Human Female Titan from Awoken Female Warlock
instrument.ts:129 Move 1 Scorched Hunter Mask Helmet to Vault from Awoken Female Warlock
instrument.ts:129 Move 1 Scorched Hunter Mask Helmet to Human Female Titan from Vault
instrument.ts:129 User initiated move: 1 Scorched Hunter Grips Gauntlets to Human Female Titan from Awoken Female Warlock
instrument.ts:129 Move 1 Scorched Hunter Grips Gauntlets to Vault from Awoken Female Warlock
instrument.ts:129 Move 1 Scorched Hunter Grips Gauntlets to Human Female Titan from Vault
instrument.ts:129 User initiated move: 1 Scorched Hunter Vest Chest to Human Female Titan from Awoken Female Warlock
instrument.ts:129 Move 1 Scorched Hunter Vest Chest to Vault from Awoken Female Warlock
instrument.ts:129 Move 1 Scorched Hunter Vest Chest to Human Female Titan from Vault
instrument.ts:129 User initiated move: 1 Scorched Hunter Strides Leg to Human Female Titan from Awoken Female Warlock
instrument.ts:129 Move 1 Scorched Hunter Strides Leg to Vault from Awoken Female Warlock
instrument.ts:129 Move 1 Scorched Hunter Strides Leg to Human Female Titan from Vault
instrument.ts:129 User initiated move: 1 Scorched Hunter Cloak ClassItem to Human Female Titan from Awoken Female Warlock
instrument.ts:129 Move 1 Scorched Hunter Cloak ClassItem to Vault from Awoken Female Warlock
instrument.ts:129 Move 1 Scorched Hunter Cloak ClassItem to Human Female Titan from Vault
instrument.ts:129 User initiated move: 1 Chiron's Cure Chest to Awoken Female Warlock from Vault
instrument.ts:129 Move 1 Chiron's Cure Chest to Awoken Female Warlock from Vault
instrument.ts:129 Object
instrument.ts:129 User initiated move: 1 Apex Predator Power to Awoken Female Warlock from Awoken Female Warlock
instrument.ts:129 Pull 1 Apex Predator Power to Awoken Female Warlock from Postmaster
instrument.ts:129 Object
instrument.ts:129 Saving profile data to IDB
reducer.ts:444 prepareUpdateQueue: 1.169921875 ms
instrument.ts:129 [flushUpdates] Flushing queue of 1 updates
instrument.ts:129 [flushUpdates] got results Array(1) Array(1)
reducer.ts:444 prepareUpdateQueue: 0.361083984375 ms
instrument.ts:129 [flushUpdates] Flushing queue of 1 updates
instrument.ts:129 [flushUpdates] got results Array(1) Array(1)
2instrument.ts:129 Saving profile data to IDB
reducer.ts:444 prepareUpdateQueue: 0.363037109375 ms
instrument.ts:129 [flushUpdates] Flushing queue of 1 updates
instrument.ts:129 [flushUpdates] got results Array(1) Array(1)
instrument.ts:129 Saving profile data to IDB
instrument.ts:129 Object
instrument.ts:129 Object
instrument.ts:129 User initiated move: 1 Boots of the Great Hunt Leg to Awoken Female Warlock from Awoken Female Warlock
instrument.ts:129 Pull 1 Boots of the Great Hunt Leg to Awoken Female Warlock from Postmaster
instrument.ts:129 Saving profile data to IDB
d2-stores.ts:234 Process inventory: 117.162841796875 ms
d2-stores.ts:238 Inventory state update: 183.56494140625 ms
instrument.ts:129 Object
instrument.ts:129 Object
d2-stores.ts:234 Process inventory: 161.89892578125 ms
d2-stores.ts:238 Inventory state update: 122.53515625 ms
instrument.ts:129 Saving profile data to IDB
reducer.ts:444 prepareUpdateQueue: 1.247802734375 ms
instrument.ts:129 [flushUpdates] Flushing queue of 1 updates
instrument.ts:129 [flushUpdates] got results Array(1) Array(1)
2instrument.ts:129 Saving profile data to IDB
reducer.ts:444 prepareUpdateQueue: 0.294189453125 ms
instrument.ts:129 [flushUpdates] Flushing queue of 1 updates
instrument.ts:129 [flushUpdates] got results Array(1) Array(1)
instrument.ts:129 Saving profile data to IDB
instrument.ts:129 User initiated move: 1 Boots of Ascendancy Leg to Vault from Awoken Female Warlock
instrument.ts:129 Move 1 Boots of Ascendancy Leg to Vault from Awoken Female Warlock
instrument.ts:129 Resetting lock status of Boots of Ascendancy to true when moving to Vault to work around Bungie.net lock state bug
instrument.ts:129 Object
instrument.ts:129 User initiated move: 1 Boots of Ascendancy Leg to Awoken Female Warlock from Awoken Female Warlock
instrument.ts:129 Pull 1 Boots of Ascendancy Leg to Awoken Female Warlock from Postmaster
instrument.ts:129 User initiated move: 1 Long Shadow Kinetic to Awoken Female Warlock from Awoken Female Hunter
instrument.ts:129 Move 1 Long Shadow Kinetic to Vault from Awoken Female Hunter
instrument.ts:129 Move 1 Long Shadow Kinetic to Awoken Female Warlock from Vault
instrument.ts:129 Resetting lock status of Long Shadow to false when moving to Awoken Female Warlock to work around Bungie.net lock state bug
instrument.ts:129 User initiated move: 1 Bite of the Fox Kinetic to Awoken Female Warlock from Awoken Female Hunter
instrument.ts:129 Move 1 Bite of the Fox Kinetic to Vault from Awoken Female Hunter
instrument.ts:129 Move 1 Bite of the Fox Kinetic to Awoken Female Warlock from Vault
instrument.ts:129 Resetting lock status of Bite of the Fox to false when moving to Awoken Female Warlock to work around Bungie.net lock state bug
instrument.ts:129 Object
instrument.ts:129 User initiated move: 1 Outlast Energy to Awoken Female Warlock from Awoken Female Hunter
instrument.ts:129 Move 1 Outlast Energy to Vault from Awoken Female Hunter
instrument.ts:129 Move 1 Outlast Energy to Awoken Female Warlock from Vault
instrument.ts:129 User initiated move: 1 Felwinter's Lie Energy to Awoken Female Warlock from Awoken Female Hunter
instrument.ts:129 Move 1 Felwinter's Lie Energy to Vault from Awoken Female Hunter
instrument.ts:129 Move 1 Felwinter's Lie Energy to Awoken Female Warlock from Vault
instrument.ts:129 Object
instrument.ts:129 Object
instrument.ts:129 Object
instrument.ts:129 Object
instrument.ts:129 User initiated move: 1 Fixed Odds Power to Awoken Female Warlock from Awoken Female Hunter
instrument.ts:129 Move 1 Fixed Odds Power to Vault from Awoken Female Hunter
instrument.ts:129 Move 1 Fixed Odds Power to Awoken Female Warlock from Vault
instrument.ts:129 User initiated move: 1 Outrageous Fortune Power to Awoken Female Warlock from Awoken Female Hunter
instrument.ts:129 Move 1 Outrageous Fortune Power to Vault from Awoken Female Hunter
instrument.ts:129 Move 1 Outrageous Fortune Power to Awoken Female Warlock from Vault
instrument.ts:129 User initiated move: 1 Wrecked Titan Helm Helmet to Awoken Female Warlock from Awoken Female Hunter
instrument.ts:129 Move 1 Wrecked Titan Helm Helmet to Vault from Awoken Female Hunter
instrument.ts:129 Move 1 Wrecked Titan Helm Helmet to Awoken Female Warlock from Vault
instrument.ts:129 User initiated move: 1 Wrecked Titan Gauntlets Gauntlets to Awoken Female Warlock from Awoken Female Hunter
instrument.ts:129 Move 1 Wrecked Titan Gauntlets Gauntlets to Vault from Awoken Female Hunter
instrument.ts:129 Move 1 Wrecked Titan Gauntlets Gauntlets to Awoken Female Warlock from Vault
instrument.ts:129 User initiated move: 1 Wrecked Titan Plate Chest to Awoken Female Warlock from Awoken Female Hunter
instrument.ts:129 Move 1 Wrecked Titan Plate Chest to Vault from Awoken Female Hunter
instrument.ts:129 Move 1 Wrecked Titan Plate Chest to Awoken Female Warlock from Vault
instrument.ts:129 User initiated move: 1 Wrecked Titan Greaves Leg to Awoken Female Warlock from Awoken Female Hunter
instrument.ts:129 Move 1 Wrecked Titan Greaves Leg to Vault from Awoken Female Hunter
instrument.ts:129 Move 1 Wrecked Titan Greaves Leg to Awoken Female Warlock from Vault
instrument.ts:129 User initiated move: 1 Tattered Titan Mark ClassItem to Awoken Female Warlock from Awoken Female Hunter
instrument.ts:129 Move 1 Tattered Titan Mark ClassItem to Vault from Awoken Female Hunter
instrument.ts:129 Move 1 Tattered Titan Mark ClassItem to Awoken Female Warlock from Vault
instrument.ts:129 Saving profile data to IDB
d2-stores.ts:234 Process inventory: 116.631103515625 ms
d2-stores.ts:238 Inventory state update: 156.88720703125 ms
instrument.ts:129 Object
instrument.ts:129 User initiated move: 1 The Supremacy Kinetic to Awoken Female Hunter from Awoken Female Warlock
instrument.ts:129 Move 1 The Supremacy Kinetic to Vault from Awoken Female Warlock
instrument.ts:129 Move 1 The Supremacy Kinetic to Awoken Female Hunter from Vault
instrument.ts:129 Resetting lock status of The Supremacy to false when moving to Awoken Female Hunter to work around Bungie.net lock state bug
instrument.ts:129 User initiated move: 1 Traveler's Chosen Kinetic to Awoken Female Warlock from Awoken Female Hunter
instrument.ts:129 Move 1 Traveler's Chosen Kinetic to Vault from Awoken Female Hunter
instrument.ts:129 Move 1 Traveler's Chosen Kinetic to Awoken Female Warlock from Vault
instrument.ts:129 Object
d2-stores.ts:234 Process inventory: 101.567138671875 ms
d2-stores.ts:238 Inventory state update: 229.743896484375 ms
instrument.ts:129 Saving profile data to IDB
d2-stores.ts:234 Process inventory: 210.8349609375 ms
d2-stores.ts:238 Inventory state update: 124.958984375 ms
instrument.ts:129 Object
d2-stores.ts:234 Process inventory: 101.6220703125 ms
d2-stores.ts:238 Inventory state update: 211.319091796875 ms
d2-stores.ts:234 Process inventory: 81.0771484375 ms
d2-stores.ts:238 Inventory state update: 108.73193359375 ms
d2-stores.ts:234 Process inventory: 54.240966796875 ms
d2-stores.ts:238 Inventory state update: 139.152099609375 ms
instrument.ts:129 Object
instrument.ts:129 Saving profile data to IDB
d2-stores.ts:234 Process inventory: 169.67578125 ms
d2-stores.ts:238 Inventory state update: 182.31494140625 ms
d2-stores.ts:234 Process inventory: 110.135986328125 ms
d2-stores.ts:238 Inventory state update: 184.10693359375 ms
@JosephBono JosephBono added the Bug label Sep 29, 2020
@JosephBono
Copy link
Author

After doing some more investigating, the issue appears to be a data issue in the Bungie API. I have opened an issue in their GitHub for this (Bungie-net/api#1303), but if anyone here knows of additional steps I should take to raise this with them I am happy to hear them.

Leaving this issue open for DIM in case the DIM contributors want to try to address this data error on their side or want to have an issue open to track the Bungie issue. If the contributors for this repro do not have a use for this issue you are welcome to close it.

Thank you for this wonderful piece of software!

@JosephBono JosephBono mentioned this issue Sep 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@delphiactual @JosephBono