Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated in Symphony 2.7.0 - public function grab(array &$param_pool=NULL) #184

Open
wdebusschere opened this issue Aug 8, 2017 · 3 comments
Assignees

Comments

@wdebusschere
Copy link
Contributor

datetime/data-sources/data.datetime.php L55

public function grab(array &$param_pool=NULL) {
$result = new XMLElement('datetime');

@nitriques nitriques self-assigned this Aug 10, 2017
@nitriques
Copy link
Member

Hi @wdebusschere this is normal behaviour. These warning will help you figure out what needs to be updated if you want to go to 3.0.0. I'll leave this issue open as we will need to change this, but only for 3.0.0 compat.

@twiro
Copy link

twiro commented Nov 28, 2017

But is it really necessary to flood the log with a message that tells me about a function that won't work in the next major release… do we do this elsewhere?

My log would be pretty clean if not for datetime telling me endless times about Datasource::grab() beeing deprecated… this shows just the last single hour of a website I just updated to 2.7.0:

bildschirmfoto 2017-11-28 um 13 34 54

These warning will help you figure out what needs to be updated if you want to go to 3.0.0.

But the current version of this extension is neither supposed nor promoted as beeing compatible with Symphony 3.0.0 – and I guess when the time comes and Symphony 3.0.0 will be released you will also release a compatible version of this extension that won't make use of Datasource::grab()

@nitriques
Copy link
Member

@twiro this already landed in 2.7.x symphonycms/symphonycms#2762

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants