-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newtonsoft.Json -> System.Text.Json #605
Merged
mpreyskurantov
merged 15 commits into
DevExpress:master
from
mpreyskurantov:newtonsoft-to-stj
Mar 7, 2024
Merged
Newtonsoft.Json -> System.Text.Json #605
mpreyskurantov
merged 15 commits into
DevExpress:master
from
mpreyskurantov:newtonsoft-to-stj
Mar 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ialize / Deserialize
…tem.Text.Json.Serialization.JsonPropertyName attr on class properties)
… (without custom IList converter), isolate true NEWTONSOFT_TESTS (all passed)
This reverts commit 56b5cdf.
…ouldSerialize (Blazor Grid3 may fails without totalCount)
IlyaKhD
reviewed
Mar 7, 2024
IlyaKhD
approved these changes
Mar 7, 2024
This was referenced Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
Structural changes:
Behavior changes:
https://github.com/dotnet/runtime/blob/main/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterOfT.cs
https://github.com/dotnet/runtime/blob/main/src/libraries/System.Text.Json/src/System/Text/Json/Reader/Utf8JsonReader.cs
That is why, it is kept the default IList traversing with further unwrap its operands tree, whose items (primitives) wrapped with JsonElement.
Testing:
Tested against the "Sample" project in this solution (JS dxDataGrid + ASP.NET MVC Backend / Controller) and a modern Blazor DxGrid https://demos.devexpress.com/blazor/Grid/DataBinding/LargeQueryableAsHttp + Data Editors (based on a legacy DxDataGrid).