Calendar: Improve aria-label in Multiple mode #28106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladaskorohodova
previously approved these changes
Sep 25, 2024
ksercs
reviewed
Sep 25, 2024
packages/devextreme/js/__internal/ui/calendar/m_calendar.base_view.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/ui/calendar/m_calendar.base_view.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/ui/calendar/m_calendar.base_view.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/calendar.markup.tests.js
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/ui/calendar/m_calendar.multiple.selection.strategy.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/ui/calendar/m_calendar.multiple.selection.strategy.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/ui/calendar/m_calendar.multiple.selection.strategy.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/ui/calendar/m_calendar.multiple.selection.strategy.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/ui/calendar/m_calendar.multiple.selection.strategy.ts
Outdated
Show resolved
Hide resolved
marker-dao
force-pushed
the
24_2_calendar_multiple_ally
branch
from
9b54698
to
251e725
Compare
EugeniyKiyashko
requested changes
Sep 26, 2024
| @@ -689,6 +689,45 @@ const getMachineTimezoneName = () => { | |||
| : null; | |||
| }; | |||
|
|
|||
| const getRangesByDates = (dates) => { | |||
There was a problem hiding this comment.
We calculate the same value for area-label three times: once for the visible view and twice for the invisible ones. Is there any way to optimize this and calculate the value only once?
There was a problem hiding this comment.
I don't think it's important, anyway we have O(n) time complexity
There was a problem hiding this comment.
We can, but for that I would introduce a new ranges option at the calendar level.
ksercs
reviewed
Sep 27, 2024
packages/devextreme/js/__internal/ui/calendar/m_calendar.base_view.ts
Outdated
Show resolved
Hide resolved
ksercs
reviewed
Sep 27, 2024
added 6 commits
September 27, 2024 13:33
…d localization && PG && Improve multiple mode label
added 10 commits
September 27, 2024 13:33
marker-dao
force-pushed
the
24_2_calendar_multiple_ally
branch
from
bef67c2
to
10a380d
Compare
ksercs
previously approved these changes
Sep 27, 2024
packages/devextreme/testing/tests/DevExpress.utils/utils.date.tests.js
Outdated
Show resolved
Hide resolved
ksercs
previously approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.