Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

darwin.js .csv output missing period data due to period -> periodLength conversion omission. #1004

Closed
shr00mie opened this issue Dec 27, 2017 · 2 comments
Closed

darwin.js .csv output missing period data due to period -> periodLength conversion omission. #1004

shr00mie opened this issue Dec 27, 2017 · 2 comments
Labels
bug

Comments

@shr00mie
Copy link
Contributor

i believe the commit which replaced all period with periodLength missed line 541 in darwin.js which is causing the "Period" column in .csv output to be empty. .json does not appear to be affected.
@DeviaVir DeviaVir added the bug label Dec 27, 2017
@shr00mie shr00mie mentioned this issue Dec 27, 2017
Merged
@DeviaVir DeviaVir reopened this Dec 28, 2017
@DeviaVir
Copy link
Owner

Is this fixed now due to your own PR?

@shr00mie
Copy link
Contributor Author

yuuuuuuuuuuuuup

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DeviaVir @shr00mie