Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

Depositing extra money & ROI #150

Closed
toastal opened this issue May 15, 2017 · 2 comments
Closed

Depositing extra money & ROI #150

toastal opened this issue May 15, 2017 · 2 comments

Comments

@toastal
Copy link

toastal commented May 15, 2017

I deposited a little extra cash/BTC because there wasn't enough to trade. However, that deposit was added to the ROI as if it were profit.

05/14/2017 10:02:02 PM EDT [    reporter]    m24913561       5 trades.                      RSI: 48 CLOSE:    $1,795.49 USD gdax.BTC-USD BAL:      $188.34 ROI:1.900 [link]
05/14/2017 10:02:02 PM EDT [      trader] gdax.BTC-USD New account balance: 0.068 BTC $66.25 USD [link]
05/14/2017 10:01:55 PM EDT [        gdax]    m24913561       5 trades. 05/14/2017 10:01:45 PM EDT  BUY         2.335 at     $1,795.46 BTC/USD [link]
05/14/2017 10:01:35 PM EDT [        gdax]    m24913561       5 trades. 05/14/2017 10:01:23 PM EDT  BUY         1.482 at     $1,794.64 BTC/USD [link]
05/14/2017 10:01:02 PM EDT [    reporter]    m24913560       4 trades.          -           RSI: 46 CLOSE:    $1,794.73 USD gdax.BTC-USD BAL:       $98.56 ROI:0.994
@carlos8f
Copy link
Contributor

Hi there,

I added a --reset_profit flag to zenbot 4 to reset the ROI to 0 in situations like this. Did you expect the ROI to be 0, or be unchanged by the balance change? If the latter, I don't think that's possible, or at least it wouldn't make sense to have a chunk of the balance not figure into the profit calc.

@toastal
Copy link
Author

toastal commented May 15, 2017

Both answers suffice my question

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants