fix: Merge pull request #234 from pvangeepuram/fix-serviceKeyPassword…

…-issue Fix the issue with generating certificate with serviceKeyPassword
Dexus · Feb 16, 2019 · 1649e7b · 1649e7b
2 parents 1b63519 + 2248228
commit 1649e7b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/lib/pem.js b/lib/pem.js
@@ -395,15 +395,15 @@ function createCertificate (options, callback) {
         }
       }
       if (options.serviceKeyPassword) {
-        helper.createPasswordFile({ 'cipher': '', 'password': options.serviceKeyPassword, 'passType': 'in' }, params, delTempPWFiles[delTempPWFiles.length])
+        helper.createPasswordFile({ 'cipher': '', 'password': options.serviceKeyPassword, 'passType': 'in' }, params, delTempPWFiles)
       }
       tmpfiles.push(options.serviceCertificate)
       tmpfiles.push(options.serviceKey)
     } else {
       params.push('-signkey')
       params.push('--TMPFILE--')
       if (options.serviceKeyPassword) {
-        helper.createPasswordFile({ 'cipher': '', 'password': options.serviceKeyPassword, 'passType': 'in' }, params, delTempPWFiles[delTempPWFiles.length])
+        helper.createPasswordFile({ 'cipher': '', 'password': options.serviceKeyPassword, 'passType': 'in' }, params, delTempPWFiles)
       }
       tmpfiles.push(options.serviceKey)
     }

diff --git a/test/pem.spec.js b/test/pem.spec.js
@@ -195,6 +195,18 @@ describe('General Tests', function () {
         })
       })
 
+      it('create cert using serviceKeyPassword', function (done) {
+        pem.createCertificate({
+          serviceKeyPassword: 'min4chars',
+          selfSigned: true
+        }, function (error, data) {
+          hlp.checkError(error)
+          hlp.checkCertificate(data, true)
+          hlp.checkTmpEmpty()
+          done()
+        })
+      })
+
       it('create cert using pkey w/ password; create pkcs12', function (done) {
         pem.createCertificate({
           clientKey: pwkey.key,