Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

stable tag for containers #112

Open
garryod opened this issue Jan 19, 2023 · 11 comments
Open

stable tag for containers #112

garryod opened this issue Jan 19, 2023 · 11 comments
Assignees
Labels
enhancement New feature or request

Comments

@garryod
Copy link
Member

garryod commented Jan 19, 2023

During development of services it would be nice if we could have a stable tag for containers which would be applied to non alpha/beta/dev releases, allowing latest to point to potentially unstable releases

@garryod garryod added the enhancement New feature or request label Jan 19, 2023
@coretl
Copy link
Contributor

coretl commented Jan 19, 2023

I'd prefer to detect pre-release tags (alpha/beta/dev), release them, but not point latest at them. Is this possible with the docker action?

@garryod
Copy link
Member Author

garryod commented Jan 19, 2023

That seems reasonable, could we point nightly or something similar at them instead? And yeah, just need to add a bit of logic to the tags section of docker/metadata-action

@coretl
Copy link
Contributor

coretl commented Jan 19, 2023

We already do something similar for github releases, could extract this somewhere:

prerelease: ${{ contains(github.ref_name, 'a') || contains(github.ref_name, 'b') || contains(github.ref_name, 'rc') }}

@gilesknap
Copy link
Contributor

I can see a nice way to implement this using the same condition as prerelease.

Will make a PR.

@gilesknap
Copy link
Contributor

do we want
stable: for non alpha/beta
nightly: for alpha/beta

and no latest?

@coretl
Copy link
Contributor

coretl commented Jan 19, 2023

I would prefer latest pointing to latest non-prerelease version, and requiring people to point at a specific pre-release version. @garryod would this suit you?

@gilesknap
Copy link
Contributor

I like that - and it matches what for example python does on dockerhub https://hub.docker.com/_/python/tags

@garryod
Copy link
Member Author

garryod commented Jan 19, 2023

I would prefer a nightly or equivalent, but I can work with pointing to specific versions

@gilesknap
Copy link
Contributor

gilesknap commented Jan 19, 2023

I've said I'd make a PR but I see this is assigned to you Garry - and I see you know about the enable flag for https://github.com/docker/metadata-action tags.

@coretl
Copy link
Contributor

coretl commented Jan 19, 2023

I don't mind who does this. Who would like to make the PR?

@garryod
Copy link
Member Author

garryod commented Jan 19, 2023

Went ahead and tried this and found some weirdness due to latest being applied by default. It seems that anything but latest is suggested for moving tags, see: https://vsupalov.com/docker-latest-tag/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants