Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Git extra bash completion in dev container #126

Open
callumforrester opened this issue Mar 24, 2023 · 5 comments
Open

Git extra bash completion in dev container #126

callumforrester opened this issue Mar 24, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@callumforrester
Copy link
Contributor

Would be nice to run curl https://raw.githubusercontent.com/git/git/master/contrib/completion/git-completion.bash -o ~/.git-completion.bash as a setup setp of the dev container. Mostly making this issue so I don't forget, will submit a PR in due course unless I've missed something obvious.

@callumforrester callumforrester added enhancement New feature or request question Further information is requested labels Mar 24, 2023
@callumforrester callumforrester self-assigned this Mar 24, 2023
@callumforrester
Copy link
Contributor Author

@gilesknap is this all that's needed?

@garryod
Copy link
Member

garryod commented Mar 30, 2023

Whilst I can't see any reason you wouldn't want this, surely the fact we mount ~/.bashrc would allow users who want this to have this without needing it in the dev container itself?

@gilesknap
Copy link
Contributor

gilesknap commented Mar 30, 2023

@callumforrester yes that is what is needed.
@garryod I did not think we mounted .bashrc in skeleton devcontainers most things would break unless your host environ and container environ were very similar. (we do it for dev-c7 but that is the only one)

We have deliberately kept the devcontainer pretty minimal but this does make it not much fun to use!.

My approach to having a nice experience with devcontainers is to have my own global python/epics devcontainer in the form of dev-e7 see https://epics-containers.github.io/main/user/tutorials/02_devcontainer.html.
I add multiple python and other folders to the one container and its the only dev environment I use.

@gilesknap
Copy link
Contributor

One other point. I usually launch devcontainers with their workspace mounted inside the container as the same path outside. Then I can do most things like git commands outside. The dev-e7 example abpve uses this - see the devcontainer.json

@garryod
Copy link
Member

garryod commented Mar 30, 2023

@garryod I did not think we mounted .bashrc in skeleton devcontainers most things would break unless your host environ and container environ were very similar. (we do it for dev-c7 but that is the only one)

Ah yeah, it's only .inputrc my mistake

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants