Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command Migration: ('EXPIRE', 'EXPIREAT', 'EXPIRETIME', 'TTL', 'PTTL') #1013

Open
4 tasks
AshwinKul28 opened this issue Oct 8, 2024 · 11 comments · May be fixed by #1149
Open
4 tasks

Command Migration: ('EXPIRE', 'EXPIREAT', 'EXPIRETIME', 'TTL', 'PTTL') #1013

AshwinKul28 opened this issue Oct 8, 2024 · 11 comments · May be fixed by #1149
Assignees
Labels
migration -- command Migrates current eval to a refactored eval for all protocols functionality

Comments

@AshwinKul28
Copy link
Contributor

This issue tracks the migration of the mentioned commands - ('EXPIRE', 'EXPIREAT', 'EXPIRETIME', 'TTL', 'PTTL') to make them compatible across the three protocols supported by the Dice database: RESP, HTTP, and WebSocket.
DiceDB now supports more than one protocols (Resp/http/websocket). We don't want eval operation of each command to be strictly bound with any of the protocols. Currently eval function return statements of each command is bounded to the RESP protocol.

The migration is required because:

  • The current implementation is specific to the RESP protocol
  • Evaluation functions of each command must be refactored to ensure protocol-agnostic behavior.
  • Evaluation functions should return raw responses instead of protocol specific responses.

The goal is to make the command logic protocol-independent, allowing all three protocols to call the same core functionality seamlessly.

Requirements

  • Refactor the evaluation function of [Command Name] to be generic.
  • Ensure the evaluation function does not include protocol-specific logic.

Migration Steps

  1. Analyze Current Implementation

    • Review the current codebase to understand how the command logic is implemented.
  2. Refactor Return Logic

    • Create a new function with the function definition as evalXXX(args []string, store *dstore.Store) *EvalResponse under the file /internal/eval/store_eval.go
    • Analyse return statements of the eval and modify them to send raw types without encoding
    • Use errors in the return statements from /errors/migrated_errors.go file
    • Use perdefined responses from /internal/clientio/resp.go file as RespType variables
  3. Command/Worker specific Changes

    • Make IsMigrated flag to true in the commands information under /internal/eval/commands.go file.
    • Use the newly written eval function against the NewEval parameter in the same command structure.
    • Delete the old eval function from the /internal/eval/eval.go file.
    • Add the migrated command to the /internal/worker/CommandsMeta map and make it's type as SingleShard
  4. Update Unit Tests

    • Refactor existing unit tests to accommodate the new implementation.
    • Add new unit tests if necessary to cover all possible cases.
  5. Integration Tests

    • Run all integration tests to ensure successful migration.
    • Ensure that each protocol (RESP, HTTP, WebSocket) works correctly after migration.

Checklist

  • Migrated the evalXXX function with the latest definition
  • Update or add unit tests for the new implementation.
  • All unit tests pass successfully.
  • Ensure all integration tests pass successfully.

Additional Notes

  • Describe any edge cases that need to be handled in the generic function.
  • Mention any protocol-specific optimizations required in wrappers.

If there are any questions or concerns about this migration, please mention them here.

Related Issues/PRs

  • Sample implementation for the Get, Set, GetSet and SetEx can be found in this Pull Request.
@abrahamvineel
Copy link
Contributor

@AshwinKul28 can you please assign this to me?

@AshwinKul28
Copy link
Contributor Author

Awesome @abrahamvineel ! Go for it! 🙌

@abrahamvineel abrahamvineel removed their assignment Oct 10, 2024
@abrahamvineel
Copy link
Contributor

@AshwinKul28 Sorry, I am unable to take up this task now. I have unassigned it and will post in the chat for anyone to pick it up.

@hiteshidudeja
Copy link

Hey @AshwinKul28, can I pick this up if no one is assigned this task currently?

@AshwinKul28
Copy link
Contributor Author

HI @hiteshidudeja , I hope you are doing well. Do you happen to have any updates on this? If you've any doubts please let us know on the discord.

@hiteshidudeja
Copy link

Hey @AshwinKul28 , I am actively working on this issue. Will let you know if I face any issues. Thanks!

@soumya-codes
Copy link
Contributor

@Ehijoe hope you are doing well. Any updates on the progress? We are targeting these issues little aggressively as we maintaining the commands across two separate servers is getting very cumbersome.

@soumya-codes soumya-codes added the migration -- command Migrates current eval to a refactored eval for all protocols functionality label Oct 17, 2024
@hiteshidudeja
Copy link

Hey @soumya-codes @AshwinKul28 , apologies for the delay in informing you. Unfortunately, I won’t be able to work on this issue due to unforeseen circumstances, so I will be unassigning myself. Sorry for any inconvenience this may cause.

@hiteshidudeja hiteshidudeja removed their assignment Oct 17, 2024
@SyedMa3
Copy link
Contributor

SyedMa3 commented Oct 17, 2024

Hesitant to pick this up after seeing the conversation history 😛
@soumya-codes Can you assign this to me?

Hopefully will be able to complete 🤞

@apoorvyadav1111
Copy link
Contributor

Thanks for picking this up @SyedMa3 . Assigned.

@soumya-codes
Copy link
Contributor

Hesitant to pick this up after seeing the conversation history 😛
@soumya-codes Can you assign this to me?

Hopefully will be able to complete 🤞

@SyedMa3 I am sure you will be able to complete this. This is something simpler than what you have done before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration -- command Migrates current eval to a refactored eval for all protocols functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants