-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Command Migration: ('EXPIRE', 'EXPIREAT', 'EXPIRETIME', 'TTL', 'PTTL') #1013
Comments
@AshwinKul28 can you please assign this to me? |
Awesome @abrahamvineel ! Go for it! 🙌 |
@AshwinKul28 Sorry, I am unable to take up this task now. I have unassigned it and will post in the chat for anyone to pick it up. |
Hey @AshwinKul28, can I pick this up if no one is assigned this task currently? |
HI @hiteshidudeja , I hope you are doing well. Do you happen to have any updates on this? If you've any doubts please let us know on the discord. |
Hey @AshwinKul28 , I am actively working on this issue. Will let you know if I face any issues. Thanks! |
@Ehijoe hope you are doing well. Any updates on the progress? We are targeting these issues little aggressively as we maintaining the commands across two separate servers is getting very cumbersome. |
Hey @soumya-codes @AshwinKul28 , apologies for the delay in informing you. Unfortunately, I won’t be able to work on this issue due to unforeseen circumstances, so I will be unassigning myself. Sorry for any inconvenience this may cause. |
Hesitant to pick this up after seeing the conversation history 😛 Hopefully will be able to complete 🤞 |
Thanks for picking this up @SyedMa3 . Assigned. |
@SyedMa3 I am sure you will be able to complete this. This is something simpler than what you have done before. |
This issue tracks the migration of the mentioned commands - ('EXPIRE', 'EXPIREAT', 'EXPIRETIME', 'TTL', 'PTTL') to make them compatible across the three protocols supported by the Dice database: RESP, HTTP, and WebSocket.
DiceDB now supports more than one protocols (Resp/http/websocket). We don't want eval operation of each command to be strictly bound with any of the protocols. Currently eval function return statements of each command is bounded to the RESP protocol.
The migration is required because:
The goal is to make the command logic protocol-independent, allowing all three protocols to call the same core functionality seamlessly.
Requirements
[Command Name]
to be generic.Migration Steps
Analyze Current Implementation
Refactor Return Logic
evalXXX(args []string, store *dstore.Store) *EvalResponse
under the file/internal/eval/store_eval.go
/errors/migrated_errors.go
file/internal/clientio/resp.go
file as RespType variablesCommand/Worker specific Changes
IsMigrated
flag to true in the commands information under/internal/eval/commands.go
file.NewEval
parameter in the same command structure./internal/eval/eval.go
file./internal/worker/CommandsMeta
map and make it's type asSingleShard
Update Unit Tests
Integration Tests
Checklist
Additional Notes
If there are any questions or concerns about this migration, please mention them here.
Related Issues/PRs
The text was updated successfully, but these errors were encountered: