Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E-Hentai metadata plugin ignores source tag if set to run automatically #919

Closed
RodolfoFigueroa opened this issue Dec 5, 2023 · 1 comment

Comments

@RodolfoFigueroa
Copy link
Contributor

RodolfoFigueroa commented Dec 5, 2023

LRR Version and OS

  • Version: 0.9.0
  • OS: Debian 11
  • Installation method: Docker

Bug Details

When adding an exhentai archive via URL, the downloader will set the source tag with the provided URL. However, if the E-Hentai metadata plugin is set to run automatically, it will ignore this tag, and instead fall back to title/cover, which may cause galleries to be improperly tagged if some other gallery matches the given search. In some cases, it may even add a second competing source tag (as mentioned in #907).

This can be seen in the following logs, corresponding to this gallery; the last line indicates the metadata plugin is using the archive title.

Matching Logs

[2023-12-04 21:32:44] [EH Downloader] [info] Final URL obtained: https://rrxuxxkmbmskpyrurcgo.hath.network/archive/2584391/bfb2c2dd96019ccd6a1a2607afebb4740e6809ea/23d56bxa4qr/0 
[2023-12-04 21:32:49] [E-Hentai Login] [info] Cookies provided (<redacted>)!
[2023-12-04 21:32:49] [E-Hentai] [debug] Using URL https://exhentai.org?advsearch=1&f_sfu=on&f_sft=on&f_sfl=on&f_search=%22%5BOOO%5D%20The%20Winner%20Takes%20it%20All%20%28Splatoon%29%22 (archive title)
@RodolfoFigueroa RodolfoFigueroa changed the title E-Hentai plugin not using source tag if run automatically E-Hentai plugin ignores source tag if set to run automatically Dec 5, 2023
@RodolfoFigueroa RodolfoFigueroa changed the title E-Hentai plugin ignores source tag if set to run automatically E-Hentai metadata plugin ignores source tag if set to run automatically Dec 5, 2023
@RodolfoFigueroa RodolfoFigueroa closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2023
@RodolfoFigueroa
Copy link
Contributor Author

RodolfoFigueroa commented Dec 5, 2023

Caused by #920

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant