Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong HTML comments #22

Closed
rowild opened this issue Jan 9, 2019 · 4 comments
Closed

Wrong HTML comments #22

rowild opened this issue Jan 9, 2019 · 4 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed
Milestone

Comments

@rowild
Copy link

rowild commented Jan 9, 2019

Hitting sth like CTRL - Slash on order to comment out a HTML passage generates 2 slashes instead of

I don't know if this intended behaviour or a bug. Maybe someone could clarify...

BTW: Is this extension still in development?

@Betanu701
Copy link
Member

@rowild Thanks for the issue. The extension is still under development, I just have not had time to learn/work on the other components that are needed to get more features. Basically I need to learn how to create the language server, and hopefully pull in the built in languages so I don't have to rewrite the entire libraries.

As far as your issue goes, this could be due to the fact that ejs is mostly javascript with html sugar, so the "comment out" would go to double slash by default. When I initial wrote the plugin, it relied on regex but could only read line by line. It was difficult just to get the ejs tags to read on a seperate line. I do not know if the key bindings for line level comment allow for 2 separate languages as well.

@Betanu701
Copy link
Member

@rowild If you are up to the task, you can see if there is a way for having 2 seperate language line level comments for key bindings.

@Betanu701 Betanu701 added the help wanted Extra attention is needed label Jan 9, 2019
@rowild
Copy link
Author

rowild commented Jan 9, 2019

@Betanu701 Thank you for your detailed answer and the hints, where to look for the solution! Currently I am not up to the task, but I intend to dig into VSCode extension programming soon. It seems just to be too important to ignore.
Let's keep this issue open, please, if that is all right with you, and come back to it later.

Thanks again! Good luck with your work!

@Betanu701
Copy link
Member

@rowild I have no problem keeping this open. If you want to get into VSCode extensions, you are more than welcome to help out on this one, when you find the time. I included all my resources and howtos in the readme of the extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants