Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

double slash comment for single line EJS tags #28

Closed
Betanu701 opened this issue Mar 8, 2019 · 1 comment
Closed

double slash comment for single line EJS tags #28

Betanu701 opened this issue Mar 8, 2019 · 1 comment
Assignees
@ExE-Boss
Labels
bug Something isn't working

Comments

@Betanu701
Copy link
Member

<% //foo; %>

Once the code is commented out, the highlighting does not pick up final ejs tag on same line.
@ExE-Boss ExE-Boss added the bug Something isn't working label Mar 14, 2019
@ExE-Boss ExE-Boss mentioned this issue Mar 17, 2019
Merged
@ExE-Boss ExE-Boss self-assigned this Mar 17, 2019
@ExE-Boss
Copy link
Collaborator

ExE-Boss commented Mar 19, 2019 •
edited
Loading

Fixed by f2cf103.

Note that multi‑line comments take precedence over EJS closing tags:

Stuff
<%/*%>
Hidden
<%*/%>
Visible

results in:

Stuff

Visible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ExE-Boss ExE-Boss

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ExE-Boss @Betanu701