Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change internal representation of rsx to treat components and elements the same #2255

Closed
jkelleyrtp opened this issue Apr 5, 2024 · 1 comment
Closed

Change internal representation of rsx to treat components and elements the same #2255

jkelleyrtp opened this issue Apr 5, 2024 · 1 comment
Labels
rsx Related to rsx or the dioxus-rsx crate tweak Small changes to improve experience

Comments

@jkelleyrtp
Copy link
Member

Feature Request

We have lots of duplicated code to handle components and elements differently in rsx! when we could share the vast majority of code and simply have diverging approaches to codegen. This would help us avoid bugs like #2252 where the autoformatter drops keys, among other issues.
@jkelleyrtp jkelleyrtp added the tweak Small changes to improve experience label Apr 5, 2024
@ealmloff ealmloff added the rsx Related to rsx or the dioxus-rsx crate label Apr 5, 2024
@jkelleyrtp
Copy link
Member Author

Done in #2258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rsx Related to rsx or the dioxus-rsx crate tweak Small changes to improve experience
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jkelleyrtp @ealmloff