Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target languages from Crowdin introduce some formating errors #1542

Open
magul opened this issue Jul 28, 2019 · 3 comments
Open

Target languages from Crowdin introduce some formating errors #1542

magul opened this issue Jul 28, 2019 · 3 comments

Comments

@magul
Copy link
Member

magul commented Jul 28, 2019

Issue description

Exporting languages from Crowdin contains formatting errors. There were first spotted in #1539

In source language we have there

<!--sec data-title="Chromebook setup (if you're using one)"
data-id="chromebook_setup" data-collapse=true ces-->
{% include "/chromebook_setup/instructions.md" %}
<!--endsec-->

which is not translated by Crowdin and unfortunatelly target langueges containes different formatting there:

<!--sec data-title="Chromebook setup (if you're using one)"
data-id="chromebook_setup" data-collapse=true ces--> {% include "/chromebook_setup/instructions.md" %} 

<!--endsec-->

Language

All languages exported from Crowdin.

Operating system

All.

@das-g
Copy link
Member

das-g commented Jul 28, 2019

Has this been brought up with the Crowdin staff? They might be able to do something about that. (E.g. introduce a GitBook-flavoured variant of MarkDown as new format.)

@magul
Copy link
Member Author

magul commented Jul 29, 2019

Not yet, was on weekend city break so with limited access to network. Do you want to push that topic there? I doubt that it could be solved somehow, as we're using pretty low level, raw formatting here:

<!--sec data-title="Chromebook setup (if you're using one)"
data-id="chromebook_setup" data-collapse=true ces-->
{% include "/chromebook_setup/instructions.md" %}
<!--endsec-->

Also worth fixing is translation of data-title (as it's not visible there at all).

@magul
Copy link
Member Author

magul commented Jul 29, 2019

Actually, I knew that there was a plan to abandon that <!--sec... solution. I found #1173, maybe we should move toward that direction? These {% ... %} should be properly rendered on Crowdin, should be translatable and should render in targeted languages properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants