Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Sidebar Functionality #97

Open
trillium opened this issue Oct 3, 2022 · 1 comment
Open

Improve Sidebar Functionality #97

trillium opened this issue Oct 3, 2022 · 1 comment

Comments

@trillium
Copy link

trillium commented Oct 3, 2022


name: Feature request
about: Improve sidebar functionality
title: ''
labels: ''
assignees: ''


Improve Sidebar Functionality

Is your feature request related to a problem? Please describe.

Escape key, clicking outside of the sidebar, and clicking on internal page navigation links within sidebar do not close sidebar.

Describe the solution you'd like

  • Close sidebar when escape key is pressed
  • Close sidebar when click is registered outside of sidebar

Describe alternatives you've considered

I've made a functional update for Talon Wiki with the behavior listed above here, but it's written in javascript and changes a few things such as element IDs that you may choose to do differently.

Additional context

Thanks for building a great tool, I'd like to give back a little if able :)

@Yehonal
Copy link
Member

Yehonal commented Apr 23, 2023

Hi! Sorry for the huge delay

Thanks for using the git-wiki. Looking at your changes in Talon Wiki I think they are quite safe to be applied here as well, if you want you can open a PR and I can test and approve them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants