Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Show staff list #757

Open
ry-itto opened this issue Feb 11, 2020 · 5 comments
Open

[iOS] Show staff list #757

ry-itto opened this issue Feb 11, 2020 · 5 comments
Assignees

Comments

@ry-itto
Copy link
Member

ry-itto commented Feb 11, 2020

Kind (Required)

  • Proposal / Discussion

Overview (Required)

  • Show staff list.
    • Transition from About DroidKaigi view's Staff list.

Links

@uhooi
Copy link

uhooi commented Feb 11, 2020

🙋

@ry-itto
Copy link
Member Author

ry-itto commented Feb 11, 2020

Thanks!! Assigned 👍

@uhooi
Copy link

uhooi commented Feb 11, 2020

@ry-itto Where is the staff list get API specification?

@ry-itto
Copy link
Member Author

ry-itto commented Feb 11, 2020

@uhooi
There are no API specification as far as I know. 😢

To implement this feature,
Please make getStaffs() method at KtorDroidKaigiApi.kt. That has callback and not suspend method like this

override fun getSponsors(
callback: (response: SponsorListResponse) -> Unit,
onError: (error: Exception) -> Unit
) {
GlobalScope.launch(requireNotNull(coroutineDispatcherForCallback)) {
try {
val response = getSponsors()
callback(response)
} catch (ex: Exception) {
onError(ex)
}
}
}

And use this method in iOS project.
For example,

import ioscombined

class Hoge {
    func fetchHoge() {
        ApiComponentKt.generateDroidKaigiApi().getStaffs {
            // do something.
        }
    }
}

If this is insufficient, please tell me! 🙏

@uhooi
Copy link

uhooi commented Feb 24, 2020

@ry-itto
Cancel work because DoroidKaigi 2020 was canceled😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants