Auto-insert RTL at end of 3D mapping mission

[zlite]

If a circle mode 3D mapping mission is invoked, automatically add a RTL-equivalent waypoint after that returns to home and lands. (Right now I have to add that manually each time, which is a hassle)

[squilter]

@arthurbenemann would it be appropriate to put this in sendMissionToAPM() in org.droidplanner.core.mission.Mission ?

A quick check to make sure no land or RTL is already in missionItems, then append an RTL.

[Thalek]

My only comment is that the moment someone comes up with a mission that doesn't want an RTL at the end, this feature will become a bug.

[arthurbenemann]

Let's make the check on the upload event, and show a dialog to the user querying about start and finish of mission.

[chriselsen]

How about creating a new section under settings, called "Mission Planning".
Then under this section add the configuration item "Always complete Mission with RTL", which is enabled by default.
This way Chris gets his desired behavior, Thalek's concern is addressed and users aren't bothered by a million popups asking "Do you really want to...".

[Thalek]

Works for me. What's your opinion, Arthur?

[arthurbenemann]

@Thalek I'm ready to merge the PR if someone writes it.

[Thalek]

Makes me wish my coding skills weren't so out of date. [wry smile]

[arthurbenemann]

Done at #1142