Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for decimal data type #192

Open
chrishamm opened this issue Oct 6, 2023 · 3 comments
Open

Add support for decimal data type #192

chrishamm opened this issue Oct 6, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@chrishamm
Copy link
Contributor

DSF API only exposes float (single precision) data at present. This needs to be enhanced to support .NET decimal values by default, which will also allow display of an arbitrary number of decimal digits. Support for this needs to be implemented in RRF, too.

@chrishamm chrishamm added the enhancement New feature or request label Oct 6, 2023
@chrishamm chrishamm added this to the Version 3.6 milestone Oct 6, 2023
@chrishamm chrishamm self-assigned this Oct 6, 2023
@dc42
Copy link

dc42 commented Oct 6, 2023

Why?

@chrishamm
Copy link
Contributor Author

To fix #187. Also, when you parse e.g. 12.000 and convert it back to a string, 12.000 is output instead of 12. If you want to output a specific number of decimal points, that's the best way to go.

@dc42
Copy link

dc42 commented Oct 12, 2023

When RRF stores a float in an ExpressionValue, the value already includes a number of significant decimal places. I think all we need to do is to have that number returned to DSF along with the float value, whenever EvaluateExpression returns a value to DSF. That requires a change to DataTransfer::WriteEvaluationResult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants