Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when deleting last Macro in macro editor #119

Closed
AlexDygma opened this issue Nov 11, 2020 · 0 comments · Fixed by #121
Closed

Crash when deleting last Macro in macro editor #119

AlexDygma opened this issue Nov 11, 2020 · 0 comments · Fixed by #121
Labels
bug Something isn't working

Comments

@AlexDygma
Copy link
Member

Describe the bug
When deleting the last macro in the list of the Macro editor, Bazecor crashes

To Reproduce
Steps to reproduce the behavior:

  1. Go to the macro editor
  2. delete all macros
  3. Bazecor crashes

Expected behavior
Bazecor allows you to clear all macros

Screenshots
StackTrace:
/Users/dygma/raise/OldBaz/Bazecor/node_modules/react-beautiful-dnd/dist/react-beautiful-dnd.cjs.js:5299 react-beautiful-dndAn error has occurred while a drag is occurring.Any existing drag will be cancelled.> Uncaught TypeError: Cannot read property 'actions' of undefined👷‍ This is a development only message. It will be removed in production builds.
printFatalError @ /Users/dygma/raise/OldBaz/Bazecor/node_modules/react-beautiful-dnd/dist/react-beautiful-dnd.cjs.js:5299
/Users/dygma/raise/OldBaz/Bazecor/node_modules/react-beautiful-dnd/dist/react-beautiful-dnd.cjs.js:5301 raw ErrorEvent
printFatalError @ /Users/dygma/raise/OldBaz/Bazecor/node_modules/react-beautiful-dnd/dist/react-beautiful-dnd.cjs.js:5301
webpack-internal:///./src/renderer/components/MacroManager/MacroForm.js:330 Uncaught TypeError: Cannot read property 'actions' of undefined
at MacroForm.render (webpack-internal:///./src/renderer/components/MacroManager/MacroForm.js:330)
at finishClassComponent (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:14706)
at updateClassComponent (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:14661)
at beginWork (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:15609)
at performUnitOfWork (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:19277)
at workLoop (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:19317)
at HTMLUnknownElement.callCallback (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:149)
at Object.invokeGuardedCallbackDev (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:199)
at invokeGuardedCallback (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:256)
at replayUnitOfWork (webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:18543)
/Users/dygma/raise/OldBaz/Bazecor/node_modules/react-beautiful-dnd/dist/react-beautiful-dnd.cjs.js:5327 Uncaught ErrorEvent
webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:17082 The above error occurred in the component:
in MacroForm
in WithStyles(MacroForm) (created by MacroManager)
in div (created by CardContent)
in CardContent
in WithStyles(CardContent) (created by MacroManager)
in div (created by Paper)
in Paper
in WithStyles(Paper) (created by Card)
in Card
in WithStyles(Card) (created by MacroManager)
in div (created by MacroManager)
in RootRef (created by Modal)
in div (created by Modal)
in Portal (created by Modal)
in Modal
in WithStyles(Modal) (created by MacroManager)
in MacroManager
in WithStyles(MacroManager) (created by MacroMenu)
in div (created by MacroMenu)
in div (created by MacroMenu)
in MacroMenu
in WithStyles(MacroMenu) (created by KeySelector)
in div (created by KeySelector)
in div (created by Paper)
in Paper
in WithStyles(Paper) (created by KeySelector)
in KeySelector
in WithStyles(KeySelector) (created by Editor)
in Transition (created by Slide)
in EventListener (created by Slide)
in Slide
in WithTheme(Slide) (created by Editor)
in Editor
in WithStyles(Editor)
in WithSnackbar(WithStyles(Editor)) (created by App)
in div
in FocusHandlerImpl
in FocusHandler
in RouterImpl
in Location
in Router (created by App)
in main (created by App)
in LocationProvider (created by App)
in div (created by App)
in MuiThemeProviderOld (created by App)
in App
in WithStyles(App)
in WithSnackbar(WithStyles(App))
in SnackbarProvider

React will try to recreate this component tree from scratch using the error boundary you provided, LocationProvider.

Desktop (please complete the following information):

  • OS: All
  • Bazecor Version: 0.2.3

Additional context
Only happens when deleting the last macro available.

@AlexDygma AlexDygma added the bug Something isn't working label Nov 11, 2020
@AlexDygma AlexDygma linked a pull request Nov 11, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant