Feat: update SDWebImage to latest ver #1034
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1034 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 38 38
Branches 5 5
=========================================
Hits 38 38 ☔ View full report in Codecov by Sentry. |
| @@ -16,6 +16,6 @@ Pod::Spec.new do |s| | |||
| s.source_files = "ios/**/*.{h,m}" | |||
|
|
|||
| s.dependency 'React-Core' | |||
| s.dependency 'SDWebImage', '~> 5.11.1' | |||
| s.dependency 'SDWebImage', '~> 5.18.7' | |||
There was a problem hiding this comment.
I would suggest to use more relaxed version requirements like:
s.dependency 'SDWebImage', '~> 5.18'
s.dependency 'SDWebImageWebPCoder', '~> 0.14'
This is more conventional in podspecs unless we have a really good reason to restrict it.
|
@DylanVann, could you please consider merging this PR with suggested changes and make a patch release? That would unblock a lot of people as we have to update |
|
@DylanVann do you have plans to merge this PR? We also need the updated version of SDWebImage with the Apple Privacy Manifest |
|
@DylanVann this PR seems like a great idea. Maybe merge it in ? |
|
@DylanVann Please consider responding - you're active on Github based on your profile, it will be highly appreciated if you can get the PRs merged. Many, including me, really want to use this package in production. Until then, i recommend everyone to switch to https://docs.expo.dev/versions/latest/sdk/image/ - if you're using Expo this is a good alternative. Make sure to use the cachePolicy value in order to have a peformant grid image component. |
|
DreamSportsLab has forked this repo and created new package . |
resolves #1031