Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qin.zhao/2010/i252-crash-review.diff #254

Closed
derekbruening opened this issue Nov 27, 2014 · 1 comment
Closed

qin.zhao/2010/i252-crash-review.diff #254

derekbruening opened this issue Nov 27, 2014 · 1 comment
Labels
Migrated Priority-Medium Status-Fixed Type-Review

Comments

@derekbruening
Copy link
Contributor

From [email protected] on January 25, 2010 01:55:54

This modification tries to solve issue #252: APP CRASH (1.5.0.1 okular)

It fails in instr_encode_check_reachability for instruction
0x00007f3aefba3682: movq 0x6115d7(%rip),%mm3 # 0x7f3af01b4c60
and is because a bug in mangle_rel_addr.
Register %mm3 is a 64 bit register but cannot be used in OP_mov_imm instr.

Fixed by
replace check register size with check if register is general register.

stats: 27 diff lines

Original issue: http://code.google.com/p/dynamorio/issues/detail?id=254
@derekbruening
Copy link
Contributor Author

From [email protected] on February 21, 2010 13:01:31

Status: Verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Migrated Priority-Medium Status-Fixed Type-Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@derekbruening