Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting qos in env_batch.xml no longer works #6692

Open
jonbob opened this issue Oct 16, 2024 · 4 comments · May be fixed by ESMCI/cime#4706
Open

Setting qos in env_batch.xml no longer works #6692

jonbob opened this issue Oct 16, 2024 · 4 comments · May be fixed by ESMCI/cime#4706
Assignees

Comments

@jonbob
Copy link
Contributor

jonbob commented Oct 16, 2024

I have been running on chrysalis with the "high" qos by modifying env_batch.xml with the last directive in the following snippet:

    <directives>
      <directive> --job-name={{ job_id }}</directive>
      <directive> --nodes={{ num_nodes }}</directive>
      <directive> --output={{ job_id }}.%j </directive>
      <directive> --exclusive </directive>
      <directive> --qos=high </directive>
    </directives>
    ````
That has worked until recently, but now it seems to be ignored. I can still change the qos of a run after it has been submitted using scontrol, so it's not that chrysalis no longer recognizes it.
@jonbob jonbob changed the title Setting cos in env_batch.xml no longer works Setting qos in env_batch.xml no longer works Oct 16, 2024
@rljacob rljacob added the CIME label Oct 17, 2024
@rljacob
Copy link
Member

rljacob commented Oct 17, 2024

The resulting .case.run file should look like this:

#!/usr/bin/env python3
#SBATCH  --job-name=run.20240808.piCtl.ne120pg2_r025_RRSwISC6to18E3r5.chrysalis.test2
#SBATCH  --nodes=80
#SBATCH  --output=run.20240808.piCtl.ne120pg2_r025_RRSwISC6to18E3r5.chrysalis.test2.%j
#SBATCH  --exclusive
#SBATCH  --qos=high
#SBATCH  --switches=4

But the --qos line is missing. Last CIME version where this worked: 438850986

@jasonb5
Copy link
Contributor

jasonb5 commented Oct 21, 2024

I'm looking into this now. Thanks!

@jasonb5
Copy link
Contributor

jasonb5 commented Oct 25, 2024

Ok found the issue, working on a fix.
@jonbob Just want to confirm the previous working behavior.

./cime/scripts/create_newcase --compset S --res f19_g16 --case test
cd test
./case.setup
./case.build
# edit env_batch.xml to add directive
./case.submit

@jonbob
Copy link
Contributor Author

jonbob commented Oct 30, 2024

Sorry @jasonb5 -- I missed your comment. Yes, that is the workflow that previously added the qos correctly

@jasonb5 jasonb5 linked a pull request Nov 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants