Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow providing version_code to google play download #181

Open
robotiv opened this issue Jun 1, 2024 · 0 comments
Open

Allow providing version_code to google play download #181

robotiv opened this issue Jun 1, 2024 · 0 comments

Comments

@robotiv
Copy link

robotiv commented Jun 1, 2024

Hi,

Great project! I noticed that it is not possible to specify the version_code of an APK to download from Google Play but the underlying Rust EFF library used has a 'version_code' field that is not populated.

https://github.com/EFForg/apkeep/blob/master/src/google_play.rs#L88

https://github.com/EFForg/rs-google-play/blob/master/gpapi/src/lib.rs#L257

Exposing this or mapping the existing version parameter in apkeep for google play would allow someone to download a specific build of an APK which would be very useful.

I am not proficient in Rust otherwise would try,

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant