Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Including the eosjs in a typescript project breaks tsc build #457

Closed
mwawrusch opened this issue Dec 13, 2018 · 3 comments
Closed

Including the eosjs in a typescript project breaks tsc build #457

mwawrusch opened this issue Dec 13, 2018 · 3 comments

Comments

@mwawrusch
Copy link

Version of EOSJS
20.0.0-beta2 , maybe earlier. Doesn't show with the 16.x versions.

Describe the bug
We are including eosjs in a firestore backed node project. When adding

  "eosjs": "20.0.0-beta2",

in package.json running tsc on the project directory returns with a code 2, which unfortunately breaks the firestore build process.

To Reproduce
Steps to reproduce the behavior:
see above.

Expected behavior
Return an exit code of 0

Screenshots

none

Desktop (please complete the following information):

  • OS: Mac Os
  • Node: 8.2.1
  • tsc: 2.8.3, and 3.2.2

Additional context
Add any other context about the problem here.

@jeffreyssmith2nd
Copy link
Contributor

Can you show the output from your build failure? There were significant API changes in version 20.

@mwawrusch
Copy link
Author

tsc just returns a code 2. That's the only output I get. I'll look a bit more into this over the weekend and will provide some more feedback.

@tbfleming
Copy link
Contributor

Not enough information to reproduce. Current instructions for including eosjs in projects lives in https://github.com/EOSIO/eosjs/blob/master/README.md

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants