Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Remove unnecessary call to get_block_header_state #702

Closed
jlamarr22 opened this issue Mar 6, 2020 · 2 comments
Closed

Remove unnecessary call to get_block_header_state #702

jlamarr22 opened this issue Mar 6, 2020 · 2 comments
Assignees
@jlamarr22
Labels
bug

Comments

@jlamarr22
Copy link
Contributor

jlamarr22 commented Mar 6, 2020 •
edited
Loading

Version of EOSJS
All versions

Describe the bug
generateTapos throws an error on transaction when calling get_block_header_state, but does not actually need to call it.

To Reproduce
Steps to reproduce the behavior:

  1. Spin up a new chain
  2. Generate a transaction
  3. Error in console when transact calls generateTapos

Expected behavior
Should not throw if calling generateTapos without a valid last_irreversible_block_num.

Additional context
Porting this over from #698
Co-Authored By: @UMU618 [email protected]
@jlamarr22 jlamarr22 added the bug label Mar 6, 2020
@jlamarr22 jlamarr22 mentioned this issue Mar 6, 2020
Closed
@UMU618
Copy link
Contributor

UMU618 commented Mar 6, 2020

mark #698

@jlamarr22 jlamarr22 mentioned this issue Mar 9, 2020
Merged
2 tasks
@jlamarr22 jlamarr22 self-assigned this Mar 9, 2020
@jlamarr22
Copy link
Contributor Author

Fixed in above PR.

@jlamarr22 jlamarr22 mentioned this issue Jun 2, 2020
Merged
2 tasks
This was referenced Jun 9, 2020
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jlamarr22 jlamarr22

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@UMU618 @jlamarr22