Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about correct skin_temperature CCPP name #83

Open
svahl991 opened this issue Nov 5, 2024 · 5 comments
Open

Question about correct skin_temperature CCPP name #83

svahl991 opened this issue Nov 5, 2024 · 5 comments
Labels
question Further information is requested

Comments

@svahl991
Copy link
Collaborator

svahl991 commented Nov 5, 2024

During the JCSDA JEDI variable naming sprint, we added variables to JEDI called:

skin_temperature_at_surface_where_sea
skin_temperature_at_surface_where_land
skin_temperature_at_surface_where_ice
skin_temperature_at_surface_where_snow

I was going to submit a PR to add these names to CCPP, but I do not see that CCPP names ever use the _where_ preposition. I see _in_ and I see _over_. Sometimes both in the same name, as in temperature_in_surface_snow_at_surface_adjacent_layer_over_ice.

So I'm not sure what the "correct" CCPP names should be for the four variables we added. e.g.
skin_temperature_in_surface_sea?
skin_temperature_at_surface_in_sea?

@svahl991
Copy link
Collaborator Author

svahl991 commented Nov 5, 2024

@gold2718
Copy link
Collaborator

gold2718 commented Nov 6, 2024

Is there a problem with using _over_ here? Different meaning?

@gold2718 gold2718 removed their assignment Nov 6, 2024
@travissluka
Copy link

Is there a problem with using _over_ here? Different meaning?

Yes, different meaning. With ..._where_sea for example we're looking for the temperature within the ocean, not the temperature of the atmosphere above the ocean.

@climbfuji
Copy link
Collaborator

_over_ does not mean above. Over stands for the type of the area, for example in the context of a fractional landmask where a grid cell contains areas that are over ocean and areas over land. The over stands for exactly the same thing that you are trying to describe with where.

@svahl991
Copy link
Collaborator Author

svahl991 commented Nov 8, 2024

_over_ does not mean above. Over stands for the type of the area, for example in the context of a fractional landmask where a grid cell contains areas that are over ocean and areas over land. The over stands for exactly the same thing that you are trying to describe with where.

Since there has been no more discussion on this I'll submit the PR with over, since that is the CCPP standard, and given @climbfuji 's explanation of its meaning. Although I will say that if that is the intended meaning, then where seems more intuitive to me, and doesn't hold the same possibility of being misunderstood as meaning "above", as we did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests