Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

namelist variable chl_file_fmt not broadcast #22

Open
klindsay28 opened this issue Mar 11, 2020 · 0 comments
Open

namelist variable chl_file_fmt not broadcast #22

klindsay28 opened this issue Mar 11, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@klindsay28
Copy link
Collaborator

The namelist variable chl_file_fmt is not being broadcast after the sw_absorption_nml namelist is read by master task.

If a user specifies a non-default valid value, e.g. 'nc', then the code hangs during file open, because master task calls open_read_netcdf and non-master tasks call open_read_binary.

This affects all versions of POP.

The patch is straightforward:

--- /gpfs/u/home/cmip6/cesm_tags/cesm2_omip_n02/components/pop/source/sw_absorption.F90	2019-06-15 15:12:39.421423340 -0600
+++ ./sw_absorption.F90	2020-03-11 09:46:49.052803398 -0600
@@ -327,6 +327,7 @@
    call broadcast_scalar(jerlov_water_type,     master_task)
    call broadcast_scalar(chl_option,            master_task)
    call broadcast_scalar(chl_filename,          master_task)
+   call broadcast_scalar(chl_file_fmt,          master_task)
 
    if (sw_absorption_type .ne. 'top-layer'.and.  &
           sw_absorption_type .ne. 'jerlov'.and.  &
@klindsay28 klindsay28 added the bug Something isn't working label Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant