Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-commit hooks are a royal pain in the behind #1001

Closed
valeriupredoi opened this issue Feb 12, 2021 · 2 comments
Closed

Pre-commit hooks are a royal pain in the behind #1001

valeriupredoi opened this issue Feb 12, 2021 · 2 comments
Assignees
@bouweandela @jvegreg @valeriupredoi

Comments

@valeriupredoi
Copy link
Contributor

I just had a PR merged with no effect because the pre-commit hooks reverted my wanted change, and this is just one episode of major pains in the bottom, plus there's times when I find very old commits that have been reverted but they still persist as pre-commit hooks and they need to be removed manually - can we please get rid of these if we can't make them work optimally?
@stefsmeets
Copy link
Contributor

Hi @valeriupredoi , can you give an example of what issues you are running into?

@valeriupredoi
Copy link
Contributor Author

nevermind, I must have been doing something silly, am gonna assume that anyway 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bouweandela bouweandela

@jvegreg jvegreg

@valeriupredoi valeriupredoi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@stefsmeets @bouweandela @jvegreg @valeriupredoi